Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133167: Fix compilation process with--enable-optimizations and--without-docstrings#133187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 1 commit intopython:mainfromsobolevn:issue-133167
Apr 30, 2025

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedApr 30, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While you're fixing tests on Python built with--without-docstrings, you can also fix:

test_inspecttest_pydoctest_descrtest_rlcompleter

@sobolevn
Copy link
MemberAuthor

sobolevn commentedApr 30, 2025•
edited
Loading

@vstinner compilation does not fail without--enable-optimizations, so it is related. Basically it needs to execute tests to get profile data. But, tests fail.

Tests that you've mentioned are not executed during--enable-optimizations build phase. I would prefer to fix them in the next PR. Since it would only be a test fix.

What do you think? :)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

I'm fine with fixing other tests in a follow-up PR, and leaving the NEWS entry unchanged.

sobolevn reacted with heart emoji
@sobolevnsobolevn merged commitcc39b19 intopython:mainApr 30, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 30, 2025
…` and `--without-docstrings` (pythonGH-133187)(cherry picked from commitcc39b19)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-133207 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 30, 2025
@sobolevn
Copy link
MemberAuthor

Thank you! Working on other tests 👍

vstinner reacted with thumbs up emoji

sobolevn added a commit that referenced this pull requestApr 30, 2025
…s` and `--without-docstrings` (GH-133187) (#133207)gh-133167: Fix compilation process with `--enable-optimizations` and `--without-docstrings` (GH-133187)(cherry picked from commitcc39b19)Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@rhettingerrhettingerAwaiting requested review from rhettingerrhettinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@sobolevn@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp