Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
GH-133171: Prevent combinations of--disable-gil and--enable-experimental-jit (for now)#133179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
--disable-gil *and*--enable-experimental-jit (for now)--disable-gil and--enable-experimental-jit (for now)Probably gonna conflict withGH-131751.@savannahostrowski, you can land that one first. |
| @@ -123,6 +123,13 @@ if "%do_pgo%" EQU "true" if "%platf%" EQU "x64" ( | |||
| ) | |||
| ) | |||
| if "%UseDisableGil%" EQU "true" if "%UseTIER2%" NEQ "" ( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Strictly speaking this would be better as target in pythoncore.vcxproj (see the existing_WarnAboutZlib for example), since there's norequirement to use the batch file, and it's very easy to bypass it. (The same goes for the PGO warning above, I don't remember when that was added.)
But it's not a big deal. It's relatively temporary code anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, this will only be around for 3.14. I could just put an#error in the C source or whatever, but I figure failing early is best.
Besides, it's not like there's anythingwrong with enabling both features. It just doesn't work the way you'd expect.
2da48e3 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.