Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typo at _interpretersmodule.c file#133174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nybblista
Copy link
Contributor

Fix the typo in theis_running_main function comment.

@nybblista
Copy link
ContributorAuthor

@picnixz

@StanFromIreland
Copy link
Contributor

StanFromIreland commentedApr 30, 2025
edited
Loading

This is pointless and should be closed, it is not user facing and barely a typo.

@ZeroIntensity
Copy link
Member

Yes, it's not user-facing, but it's CPython-facing! There aren't many experts on_interpreters, and I see no reason why we shouldn't fix comments explaining how it works. I agree that we should not set a precedent for future copycat PRs fixing typos, though.

@StanFromIreland
Copy link
Contributor

StanFromIreland commentedApr 30, 2025
edited
Loading

Is it really a fix of any importance though? I can read it fine without the space, I would assume most people can too.

@ZeroIntensity
Copy link
Member

Fixes without priority still have importance. If we want to close this because it's "churn," that's probably fine, but keep in mind that there is real merit to keeping comments in check,especially in parts of the codebase that lack experts.

Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with Peter -- though I'm not a huge fan of typo-only PRs, this one does seem somewhat beneficial.

A

@AA-TurnerAA-Turner merged commitb99d970 intopython:mainMay 1, 2025
55 checks passed
@nybblistanybblista deleted the fix-typo-interpreter-module branchMay 1, 2025 07:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@nybblista@StanFromIreland@ZeroIntensity@AA-Turner

[8]ページ先頭

©2009-2025 Movatter.jp