Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-144162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields#133168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
LukeGrochocki wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromLukeGrochocki:issue

Conversation

LukeGrochocki
Copy link

Fix for gh-144162

gh-133162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fields

@python-cla-bot
Copy link

python-cla-botbot commentedApr 29, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, I'd suggest looking at thedevguide for the pull request tutorial.

A number of things I'd like you to change here:

  • Please move the test to somewhere in the existingdataclass tests.
  • This needs a blurb entry per the bot, but also needs awhatsnew entry for 3.14.
  • The title should be in agh-NNNN: quick summary format.

The test is failing, FYI!

StanFromIreland

This comment was marked as duplicate.

@ericvsmith
Copy link
Member

Also, please give this a better title. I didn’t notice it in my inbox. Thanks!

@AA-TurnerAA-Turner changed the titleFix for gh-144162gh-144162: Allow for subclasses of a dataclass to define required fields when a parent has defined optional fieldsMay 4, 2025
@AA-Turner
Copy link
Member

Still needs a better title, I just copied the one from the issue.

A

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity requested changes

@StanFromIrelandStanFromIrelandStanFromIreland requested changes

@ericvsmithericvsmithAwaiting requested review from ericvsmithericvsmith is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@LukeGrochocki@ericvsmith@AA-Turner@ZeroIntensity@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp