Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Sphinx 8.1+: remove redundant--keep-going#133156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 1 commit intopython:mainfromhugovk:3.14-rm-keep-going
Apr 30, 2025

Conversation

hugovk
Copy link
Member

https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-keep-going says:

From Sphinx 8.1,--keep-going is always enabled.
...
Changed in version 8.1:sphinx-build no longer exits on the first warning, meaning that in effect--fail-on-warning is always enabled. The option is retained for compatibility, but may be removed at some later date.

We're using Sphinx 8.2:

sphinx~=8.2.0

@hugovk
Copy link
MemberAuthor

meaning that in effect--fail-on-warning is always enabled.

I think this should read--keep-going:sphinx-doc/sphinx#13520

@AA-TurnerAA-Turner merged commitc78216e intopython:mainApr 30, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks@hugovk for the PR, and@AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 30, 2025
(cherry picked from commitc78216e)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-133214 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 30, 2025
AA-Turner pushed a commit that referenced this pull requestApr 30, 2025
…) (#133214)Remove redundant ``--keep-going`` when running Sphinx (GH-133156)(cherry picked from commitc78216e)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovkhugovk deleted the 3.14-rm-keep-going branchApril 30, 2025 18:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugovk@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp