NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-133140: Add`PyUnstable_Object_IsUniquelyReferenced` for free-threading#133144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 11 commits intopython:mainfromZeroIntensity:gh-133140-unique-reference

May 5, 2025

Merged

gh-133140: Add`PyUnstable_Object_IsUniquelyReferenced` for free-threading#133144

vstinner merged 11 commits intopython:mainfromZeroIntensity:gh-133140-unique-reference

May 5, 2025

+61 −1

Conversation

Copy link

Member

ZeroIntensity commentedApr 29, 2025•
edited
Loading

cc@godlygeek

Issue:Adding an unstable C API for unique references #133140

📚 Documentation preview 📚:https://cpython-previews--133144.org.readthedocs.build/en/133144/c-api/object.html#c.PyUnstable_Object_IsUniquelyReferenced

ZeroIntensity added5 commits

April 29, 2025 06:06

Add PyUnstable_Object_IsUniquelyReferenced()

41bf51d

Add a test.

0affc47

Fix newline change.

cc85d55

Update the documentation

822ac2d

Add blurb.

b190548

ZeroIntensity added topic-C-API topic-free-threading labels

Apr 29, 2025

ZeroIntensity requested review fromencukou andcorona10

April 29, 2025 10:32

bedevere-appbot added the awaiting review label

Apr 29, 2025

bedevere-appbot mentioned this pull request

Apr 29, 2025

Adding an unstable C API for unique references#133140

Closed

ZeroIntensity added3 commits

April 29, 2025 06:57

Don't use :c:expr:

c5d1be3

Use :c:expr: where available.

8711752

Remove crashing test.

5cc3d15

colesbury mentioned this pull request

Apr 30, 2025

gh-133164: AddPyUnstable_Object_IsUniqueReferencedTemporary C API#133170

Merged

vstinner reviewed

May 1, 2025

View reviewed changes

Modules/_testcapimodule.c OutdatedShow resolvedHide resolved

vstinner reviewed

May 1, 2025

View reviewed changes

Modules/_testcapimodule.c OutdatedShow resolvedHide resolved

ZeroIntensity added3 commits

May 1, 2025 15:59

Move to object.c

d9063f5

Remove stray newline.

6a52c02

Fix merge conflicts.

ef96737

Copy link

Member

encukou commentedMay 5, 2025

+1, from the API surface point of view

colesbury approved these changes

May 5, 2025

View reviewed changes

Copy link

Contributor

colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

bedevere-appbot added awaiting merge and removed awaiting review labels

May 5, 2025

vstinner merged commitb275b8f intopython:main

May 5, 2025

46 checks passed

bedevere-appbot removed the awaiting merge label

May 5, 2025

Copy link

Member

The Py_REFCNT() documentation might be enhanced to better explain whenPy_REFCNT(obj)==1 is acceptable, and the difference betweenPyUnstable_Object_IsUniquelyReferenced() andPyUnstable_Object_IsUniqueReferencedTemporary(). But that can be done later.