Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132876: workaround broken ldexp() on Windows 10#133135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
skirpichev wants to merge8 commits intopython:main
base:main
Choose a base branch
Loading
fromskirpichev:fix-ldexp-MS/132876

Conversation

skirpichev
Copy link
Member

@skirpichevskirpichev commentedApr 29, 2025•
edited
Loading

ldexp() on Windows doesn't round subnormal results before Windows 11, but should. Python's :func:math.ldexp wrapper now does round them.

Co-authored-by: Tim Peters <tim.peters@gmail.com>
@skirpichev
Copy link
MemberAuthor

Some benchmarking in:#132876 (comment)

Copy link
Member

@tim-onetim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since this is a potentially breaking change on Windows, it really needs a NEWS entry, yes? Like

math.ldexp() on Windows failed to round subnormal results before Window 11, and Microsoft probably won't fix it for Windows 10. So Python works around the error on Windows now. This may change results (which were formerly erroneous) in rare cases.

And maybe link to the issue report?

@zooba
Copy link
Member

It has a NEWS entry, though it could include a bit more detail (such as the ranges of values that may be incorrect). And that entry will already be linked to the bug. So this change LGTM

tim-one reacted with thumbs up emoji

@skirpichevskirpichev requested a review fromzoobaApril 30, 2025 07:27
@skirpichevskirpichev added the needs backport to 3.14bugs and security fixes labelMay 7, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zoobazoobazooba approved these changes

@tim-onetim-onetim-one approved these changes

Assignees
No one assigned
Labels
awaiting mergeneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@skirpichev@zooba@tim-one
[8]ページ先頭
©2009-2025 Movatter.jp