Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-133117: Run mypy ontomllib in CI#133118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 3 commits intopython:mainfromsobolevn:mypy-tomllib
Apr 30, 2025
Merged

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedApr 28, 2025•
edited by bedevere-appbot
Loading

@@ -214,7 +214,7 @@ class Flags:
EXPLICIT_NEST = 1

def __init__(self) -> None:
self._flags: dict[str, dict] = {}
self._flags: dict[str, dict[Any, Any]] = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is fully typed already, we just need to run the CI if something changes.

Seems it wasn't fully typed already?

Please can you also submit these changes tohttps://github.com/hukkin/tomli ?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should I do it before or after this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd suggest there first, because we're sort of downstream, but no strong preference from me.

Let's ask@hukkin,@encukou and@hauntsaninja.

AlexWaygood reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hugovk reacted with rocket emoji
@sobolevn
Copy link
MemberAuthor

merging main so CLA can possibly get unstuck :(

@sobolevn
Copy link
MemberAuthor

I will keep this open for a day or so, waiting for others' feedback :)

AlexWaygood reacted with thumbs up emoji

@sobolevnsobolevn merged commit5ea9010 intopython:mainApr 30, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 30, 2025
(cherry picked from commit5ea9010)Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

GH-133192 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 30, 2025
@sobolevn
Copy link
MemberAuthor

Now I will work on enablingdisallow_any_generics = True, thanks everyone!

sobolevn added a commit that referenced this pull requestApr 30, 2025
gh-133117: Run mypy on `tomllib` in CI (GH-133118)(cherry picked from commit5ea9010)Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@ambvambvAwaiting requested review from ambv

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstra

@encukouencukouAwaiting requested review from encukouencukou is a code owner

@hauntsaninjahauntsaninjaAwaiting requested review from hauntsaninjahauntsaninja is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sobolevn@hugovk@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp