Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.13] gh-132942: Fix races in type lookup cache#133114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

nascheme
Copy link
Member

@naschemenascheme commentedApr 28, 2025
edited by bedevere-appbot
Loading

Two races related to the type lookup cache, when used in the free-threaded build. This caused test_opcache to sometimes fail (as well as other hard to re-produce failures).

@naschemenascheme added type-crashA hard crash of the interpreter, possibly with a core dump 3.13bugs and security fixes topic-free-threading labelsApr 28, 2025
Two races related to the type lookup cache, when used in thefree-threaded build.  This caused test_opcache to sometimes fail (aswell as other hard to re-produce failures).
@naschemenaschemeforce-pushed thegh-132942-tp-lookup-race-3.13 branch fromd621626 toc551898CompareApril 28, 2025 21:44
@naschemenaschemeenabled auto-merge (squash)April 28, 2025 21:55
@naschemenascheme merged commitca46ec8 intopython:3.13Apr 28, 2025
37 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable Clang 3.13 (tier-2) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1456/builds/695) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1456/builds/695

Failed tests:

  • test_interpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/threading.py", line1041, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/threading.py", line992, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/test_interpreters/test_stress.py", line47, inrun    interp= interpreters.create()  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedkTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/threading.py", line1041, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/threading.py", line992, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/test_interpreters/test_stress.py", line30, intask    interp= interpreters.create()  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL9 Refleaks 3.13 (tier-3) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1575/builds/743) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1575/builds/743

Failed tests:

  • test_descr

Failed subtests:

  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-rhel9-s390x.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from Base

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL8 Refleaks 3.13 (tier-1) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1385/builds/834) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1385/builds/834

Failed tests:

  • test_descr

Failed subtests:

  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from Base

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 FreeBSD Refleaks 3.13 (tier-3) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1615/builds/703) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1615/builds/703

Failed tests:

  • test_descr

Failed subtests:

  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/buildbot/buildarea/3.13.ware-freebsd.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from Base

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Fedora Stable Refleaks 3.13 (tier-1) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1471/builds/729) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1471/builds/729

Failed tests:

  • test_descr

Failed subtests:

  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from Base

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Fedora Stable Refleaks 3.13 (tier-2) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1512/builds/556) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1512/builds/556

Failed tests:

  • test_descr

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated
  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from BaseTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line367, intest_python_calls_appear_in_the_stack_if_perf_activatedself.assertEqual(stderr,"")~~~~~~~~~~~~~~~~^^^^^^^^^^^^AssertionError:'Warning:\nProcessed 714 events and lost 3[34 chars]\n\n' != ''- Warning:- Processed 714 events and lost 3 chunks!- - Check IO/CPU overload!-

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 RHEL8 Refleaks 3.13 (tier-2) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1445/builds/595) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1445/builds/595

Failed tests:

  • test_descr

Failed subtests:

  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-RHEL8-aarch64.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from Base

@nascheme
Copy link
MemberAuthor

I believe this has revealed a bug in the unit test that the MRO cache bug was hidding. Seegh-133122. The quick fix would be to just disable that unit test.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE Fedora Stable Refleaks 3.13 (tier-2) has failed when building commitca46ec8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1467/builds/549) and take a look at the build logs.
  4. Check if the failure is related to this commit (ca46ec8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1467/builds/549

Failed tests:

  • test_descr

Failed subtests:

  • test_type_lookup_mro_reference - test.test_descr.MiscTests.test_type_lookup_mro_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-ppc64le.refleak/build/Lib/test/test_descr.py", line5181, intest_type_lookup_mro_referenceself.assertEqual(X.mykey,'from Base')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^AssertionError:'from Base2' != 'from Base'- from Base2?          -+ from Base

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
3.13bugs and security fixestopic-free-threadingtype-crashA hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@nascheme@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp