What about a negativetimeout?

How about raise ValueError when timeout is<=0

Hmm, looking at bash functions I get conflicting results.timeout throws an error for negative values and has no limit on0, whereas other functions (e.g.read -t 0) actually use the limit (they stop instantly).

Yes, a value error is the way to go for negative timeouts.

I don't thinktimeout=0 should be treated the same astimeout=None. This isn't done anywhere else in the standard library. For example, usingasyncio as precedent:

Make sense, I'll find a way to patch it

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Thanks@Zheaoli for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

GH-133418 is a backport of this pull request to the3.13 branch.

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL8 LTO + PGO 3.x (tier-3) has failed when building commit2bbcaed.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/442/builds/9283) and take a look at the build logs.
4. Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/442/builds/9283

Failed tests:

• test_frame
• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto-pgo/build/Lib/test/test_subprocess.py", line171, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable Clang Installed 3.x (tier-3) has failed when building commit2bbcaed.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1645/builds/352) and take a look at the build logs.
4. Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1645/builds/352

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.14/test/test_subprocess.py", line177, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raisedTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.clang-installed/build/target/lib/python3.14/test/test_subprocess.py", line171, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit2bbcaed.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/352) and take a look at the build logs.
4. Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/352

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-fedora-stable-s390x.lto-pgo/build/Lib/test/test_subprocess.py", line171, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Windows Server 2022 NoGIL 3.13 (tier-1) has failed when building commit3d1b8e2.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1488/builds/1266) and take a look at the build logs.
4. Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1488/builds/1266

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_subprocess.py", line166, intest_timeout_exception    subprocess.run(['echo','hi'],timeout=-1)~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\subprocess.py", line554, inrunwith Popen(*popenargs,**kwargs)as process:~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\subprocess.py", line1039, in__init__self._execute_child(args, executable, preexec_fn, close_fds,~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                        pass_fds, cwd, env,^^^^^^^^^^^^^^^^^^^...<5 lines>...                        gid, gids, uid, umask,^^^^^^^^^^^^^^^^^^^^^^                        start_new_session, process_group)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"C:\Users\Administrator\buildarea\3.13.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\subprocess.py", line1554, in_execute_child    hp, ht, pid, tid= _winapi.CreateProcess(executable, args,~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^# no special security^^^^^^^^^^^^^^^^^^^^^...<4 lines>...                             cwd,^^^^                             startupinfo)^^^^^^^^^^^^FileNotFoundError:[WinError 2] The system cannot find the file specified

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable 3.13 (tier-3) has failed when building commit3d1b8e2.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1658/builds/128) and take a look at the build logs.
4. Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1658/builds/128

Failed tests:

• test_os
• test_subprocess

Failed subtests:

• test_timerfd_select - test.test_os.TimerfdTests.test_timerfd_select
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception
• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x/build/Lib/test/test_os.py", line4288, intest_timerfd_selectself.assertEqual(self.read_count_signaled(fd),1)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:2 != 1Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x/build/Lib/test/test_subprocess.py", line170, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL9 LTO 3.13 (tier-3) has failed when building commit3d1b8e2.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1577/builds/702) and take a look at the build logs.
4. Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1577/builds/702

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-rhel9-s390x.lto/build/Lib/test/test_subprocess.py", line170, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable Clang 3.13 (tier-3) has failed when building commit3d1b8e2.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1667/builds/128) and take a look at the build logs.
4. Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1667/builds/128

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.clang/build/Lib/test/test_subprocess.py", line176, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raisedTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.clang/build/Lib/test/test_subprocess.py", line170, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit2bbcaed.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/10590) and take a look at the build logs.
4. Check if the failure is related to this commit (2bbcaed) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/10590

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
• test_remote_stack_trace - test.test_external_inspection.TestGetStackTrace.test_remote_stack_trace
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_subprocess.py", line171, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raisedTraceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_external_inspection.py", line104, intest_remote_stack_traceself.assertEqual(stack_trace, expected_stack_trace)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Lists differ: [('fo[62 chars]y', 14), ('baz', '/tmp/test_python_m2xu4jch/tm[186 chars] 17)] != [('fo[62 chars]y', 15), ('baz', '/tmp/test_python_m2xu4jch/tm[186 chars] 17)]Traceback (most recent call last):  File"/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_subprocess.py", line177, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x Fedora Stable Refleaks 3.13 (tier-3) has failed when building commit3d1b8e2.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1662/builds/133) and take a look at the build logs.
4. Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1662/builds/133

Failed tests:

• test_subprocess
• test_socket

Failed subtests:

• testSourceAddress - test.test_socket.NetworkConnectionAttributesTest.testSourceAddress
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_subprocess.py", line170, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raisedTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_socket.py", line417, inraise_queued_exceptionraiseself.queue.get()  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_socket.py", line454, inclientRun    test_func()~~~~~~~~~^^  File"/home/buildbot/buildarea/3.13.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_socket.py", line5783, in_testSourceAddressself.assertEqual(self.cli.getsockname()[1],self.source_port)~~~~~~~~~~~~~~~~~~~~^^OSError:[Errno 9] Bad file descriptor

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 FreeBSD Refleaks 3.13 (tier-3) has failed when building commit3d1b8e2.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1615/builds/733) and take a look at the build logs.
4. Check if the failure is related to this commit (3d1b8e2) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1615/builds/733

Failed tests:

• test_subprocess

Failed subtests:

• test_timeout_exception - test.test_subprocess.ProcessTestCaseNoPoll.test_timeout_exception
• test_timeout_exception - test.test_subprocess.ProcessTestCase.test_timeout_exception

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/buildbot/buildarea/3.13.ware-freebsd.refleak/build/Lib/test/test_subprocess.py", line176, intest_timeout_exceptionself.fail("Expected TimeoutExpired exception not raised")~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Expected TimeoutExpired exception not raised