Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
typing, annotationlib: clean tests#133087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Add @cpython_only decorator to lazy import tests- Rename reference to SOURCE format- Always two newlines between test case classes- Merge two classes of ForwardRef tests- Use get_annotations instead of annotationlib.get_annotations- Format test_annotationlib with Black (not expecting that we'll keep this up but it's close to Black-formatted right now)
Let me know if there's other pieces of minor cleanup we could do on the tests. |
| @@ -6124,8 +6130,6 @@ def test_errors(self): | |||
| # We need this to make sure that `@no_type_check` respects `__module__` attr: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this comment seems orphaned now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it still makes sense referring to the classes immediately below
7f16f1b intopython:mainUh oh!
There was an error while loading.Please reload this page.
but it's close to Black-formatted right now)
ischecks against True/False, so they could hide issues if our code sets some attributes to some other object instead of a bool. I left assertTrue/assertFalse when calling functions likecallable()that are tested elsewhere.