Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-127604: ensure-ldl is passed only once to the linker#133071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 3 commits intopython:mainfrompicnixz:fix/warnings/ldl-linker-127604
Apr 28, 2025

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedApr 28, 2025•
edited by bedevere-appbot
Loading

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

In the current main branch,make shows me many lines starting withgcc -ldl -ldl -ldl -ldl -ldl -ldl. Ooops :-)

With this change, I getgcc -ldl which seems better.

@picnixzpicnixz merged commitaf3f6fc intopython:mainApr 28, 2025
45 checks passed
@picnixzpicnixz deleted the fix/warnings/ldl-linker-127604 branchApril 28, 2025 09:55
@freakboy3742
Copy link
Contributor

This looks like it's addressed the 6x-ldl issue for linux, but themacOS and iOS buildbots are still showing duplicates - I think these are coming out of the handling ofdlopen() in libFFI handling.

@picnixz
Copy link
MemberAuthor

picnixz commentedApr 28, 2025•
edited
Loading

Ah... Why is life so hard. I'm no more on my dev session and I'll be busy this afternoon. Is it possible for someone to fix this as well? An alternate fix is to not pass-ldl for dlopen() if$ac_cv_require_ldl is yes as it's already in LDFLAGS.

I'm very sorry that I failed to fix the libffi part :(

@freakboy3742
Copy link
Contributor

@picnixz#133081 is an attempt at a cleanup for Apple platforms.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@picnixz@freakboy3742@vstinner
[8]ページ先頭
©2009-2025 Movatter.jp