Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132742: Fix newly added tcflush() tests on Android#133070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
!builtbot android |
!buildbot android |
bedevere-bot commentedApr 28, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit777da5b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot android |
bedevere-bot commentedApr 28, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit58c2e60 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot android |
bedevere-bot commentedApr 28, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit3642a32 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Lib/test/test_ioctl.py Outdated
@@ -173,20 +176,22 @@ def test_ioctl_suspend_and_resume_output(self): | |||
def writer(): | |||
os.write(wfd, b'abc') | |||
write_suspended.wait() | |||
self.assertTrue(write_suspended.wait(5)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would prefer to use support.SHORT_TIMEOUT rather than hardcoded timeout. Same remark for other 5 seconds timeouts.
!buildbot android |
bedevere-bot commentedApr 28, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commitc3a0c3d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133070%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
25186c2
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
GH-133104 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.