Movatterモバイル変換

Copy link

python-cla-botbot commentedApr 28, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

bedevere-appbot added docs

Documentation in the Doc dir

skip news labels

github-project-automationbot added this toDocs PRs

github-project-automationbot moved this toTodo inDocs PRs

bedevere-appbot mentioned this pull request

shutil.which doesn't work in Docker container#132971

Closed

ZeroIntensity added the skip issue label

picnixz changed the title~~gh-132971:update shutil.which doc~~gh-132971: update shutil.which doc

picnixz changed the title~~gh-132971: update shutil.which doc~~gh-132971: updateshutil.which doc

picnixz reviewed

Doc/library/shutil.rst OutdatedShow resolvedHide resolved

picnixz removed the skip issue label

985025074 force-pushed thefix-issue-132971 branch from7fe9355 to1bc4251Compare

April 28, 2025 12:14

StanFromIreland reviewed

Doc/library/shutil.rst OutdatedShow resolvedHide resolved

985025074 added3 commits

April 29, 2025 00:11

update shutil.which doc

1bfe703

change the location of the note.

32c1c0b

use envvar for PATH

df20e17

985025074 force-pushed thefix-issue-132971 branch from1bc4251 todf20e17Compare

April 28, 2025 16:16

auvipy approved these changes

Apr 29, 2025

Copy link

auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good to me

bedevere-appbot added awaiting core review and removed awaiting review labels

Apr 29, 2025

donBarbos reviewed

Apr 29, 2025

Copy link

Contributor

donBarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM
but please don't force-push; it makes reviewing harder. Moreover, all commits are squashed upon merge anyway, so there's no need for the PR/branch to be cluttered with amendment commits. Source:devguide.

Doc/library/shutil.rst Outdated

Comment on lines 460 to 461

		specified path directly and does not search the directories listed in path
		or in the system's :envvar:`PATH` environment variable.

Copy link

Contributor

donBarbosApr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

let's wrap this line so that it doesn't exceed the length of the line

Suggested change

	specified path directly and does not search the directories listed in path
	or in the system's:envvar:`PATH` environment variable.
	specified path directly and does not search the directories listed in
	pathor in the system's:envvar:`PATH` environment variable.

Copy link

ContributorAuthor

985025074Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, I will follow that next time.Thank you.

985025074 added2 commits

April 30, 2025 10:28

Merge branch 'main' into fix-issue-132971

fba4c4b

change path to the next line

c812c94

985025074 requested a review fromdonBarbos

April 30, 2025 02:35

donBarbos approved these changes

May 1, 2025

serhiy-storchaka reviewed

May 9, 2025

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thenote directive is considered too loud. A simple paragraph is enough.

picnixz reviewed

May 9, 2025

Doc/library/shutil.rst OutdatedShow resolvedHide resolved

remove note

0bebbd4

985025074 requested a review frompicnixz

May 10, 2025 06:59

985025074 requested a review fromserhiy-storchaka

May 10, 2025 06:59

serhiy-storchaka approved these changes

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

Thank you for your contribution@985025074.

bedevere-appbot added awaiting merge and removed awaiting core review labels

serhiy-storchaka added needs backport to 3.13

bugs and security fixes

needs backport to 3.14bugs and security fixes labels

serhiy-storchaka merged commitd13d5fd intopython:main

32 checks passed

Copy link

miss-islington-appbot commentedMay 10, 2025

Thanks@985025074 for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

github-project-automationbot moved this fromTodo toDone inDocs PRs

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-132971: Update shutil.which() docs (pythonGH-133067)

9e2f9ad

(cherry picked from commitd13d5fd)Co-authored-by: Kokona <125976684+985025074@users.noreply.github.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-132971: Update shutil.which() docs (pythonGH-133067)

a88579f

(cherry picked from commitd13d5fd)Co-authored-by: Kokona <125976684+985025074@users.noreply.github.com>

Copy link

bedevere-appbot commentedMay 10, 2025

GH-133803 is a backport of this pull request to the3.14 branch.

bedevere-appbot removed the needs backport to 3.14bugs and security fixes label

Copy link

bedevere-appbot commentedMay 10, 2025

GH-133804 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

picnixz pushed a commit that referenced this pull request

[3.13]gh-132971: Update shutil.which() docs (GH-133067) (#133804)

3de6546

gh-132971: Update shutil.which() docs (GH-133067)(cherry picked from commitd13d5fd)Co-authored-by: Kokona <125976684+985025074@users.noreply.github.com>

picnixz pushed a commit that referenced this pull request