Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130197: Testpygettext output option#133041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 3 commits intopython:mainfromStanFromIreland:test-output
May 1, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedApr 27, 2025•
edited by bedevere-appbot
Loading

@bedevere-appbedevere-appbot added awaiting review testsTests in the Lib/test dir labelsApr 27, 2025
@bedevere-appbedevere-appbot mentioned this pull requestApr 27, 2025
18 tasks
Copy link
Member

@tomasr8tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's actually a bit strange that an input file is not required.. maybe it should?

@StanFromIreland
Copy link
ContributorAuthor

It should, and output should only be generated if there are msgids, but that is beyond the scope of the pr. I can open an issue for the discussion of this.

@tomasr8
Copy link
Member

that is beyond the scope of the pr

Definitely, I just found it surprising looking at the test and wondering where the input file is 😄

I think the input file should be required, could you open an issue?

@StanFromIreland

This comment was marked as resolved.

@tomasr8
Copy link
Member

How is it broken? It outputs to stdout, no?

@StanFromIreland

This comment was marked as resolved.

@serhiy-storchakaserhiy-storchaka merged commite5e51bd intopython:mainMay 1, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks@StanFromIreland for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@StanFromIrelandStanFromIreland deleted the test-output branchMay 1, 2025 16:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 1, 2025
(cherry picked from commite5e51bd)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

GH-133266 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 1, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 9, 2025
(cherry picked from commite5e51bd)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@tomasr8tomasr8Awaiting requested review from tomasr8

Assignees
No one assigned
Labels
awaiting mergeskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@StanFromIreland@tomasr8@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp