Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-127604: ensure-ldl
is passed to the linker whendladdr1
is found#133040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-127604: ensure-ldl
is passed to the linker whendladdr1
is found#133040
Uh oh!
There was an error while loading.Please reload this page.
Conversation
-ldl
is passed to the linker whendladdr1
is found-ldl
is passed to the linker whendladdr1
is foundThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but let's run buildbots to make sure we didn't break anything.
bedevere-bot commentedApr 27, 2025
🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit3d22310 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133040%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
2443662
intopython:mainUh oh!
There was an error while loading.Please reload this page.
@picnixz This seems to have resulted in the |
Looks like it's not just macOS and iOS; Ubuntu buildsnow include compilation statements like |
Aaaaaah I don't understand:( Why would it include it twice I'll investigate |
picnixz commentedApr 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Mmh, it's actually in Python/traceback.c. A bit more annoying. |
Hum. I also forgot removing |
faulthandler is built as a built-in module, since Py_FatalError() uses it (dump the backtrace and than turns off faulthandler). |
I found the issue. Because of |
picnixz commentedApr 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
PR is ready:#133071.
And yes, that's why I didn't see the warnings. I use gcc and not clang |
I was wondering if autoreconf was smart enough to deal with the extra flags. Buildbots passed so I figured it was ok :(. |
Uh oh!
There was an error while loading.Please reload this page.
Seehttps://man7.org/linux/man-pages/man3/dladdr.3.html#LIBRARY for details.
faulthandler
#127604