Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-127604: ensure-ldl is passed to the linker whendladdr1 is found#133040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedApr 27, 2025
edited
Loading

@picnixzpicnixz changed the titlegh-127605: ensure-ldl is passed to the linker whendladdr1 is foundgh-127604: ensure-ldl is passed to the linker whendladdr1 is foundApr 27, 2025
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but let's run buildbots to make sure we didn't break anything.

picnixz reacted with thumbs up emoji
@ZeroIntensityZeroIntensity added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 27, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit3d22310 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133040%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 27, 2025
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@picnixzpicnixz merged commit2443662 intopython:mainApr 27, 2025
42 checks passed
@picnixzpicnixz deleted the fix/configure/backtrace-ldflags-127604 branchApril 27, 2025 22:28
@freakboy3742
Copy link
Contributor

@picnixz This seems to have resulted in the-ldl argument being includedtwice on macOS and iOS builds. It's not causing an error, but it israising a lot of compiler warnings

@freakboy3742
Copy link
Contributor

Looks like it's not just macOS and iOS; Ubuntu buildsnow include compilation statements likegcc -shared -ldl -ldl -ldl -ldl -ldl -ldl .... It doesn't look like GCC is complaining... but I think dl might be linked. 🤣

@picnixz
Copy link
MemberAuthor

Aaaaaah I don't understand:( Why would it include it twice I'll investigate

@picnixz
Copy link
MemberAuthor

picnixz commentedApr 28, 2025
edited
Loading

Instead of adding it to all LDLFLAGS, I'll only add it the LDLFLAGS forfaulthandler

Mmh, it's actually in Python/traceback.c. A bit more annoying.

@picnixz
Copy link
MemberAuthor

Hum. I also forgot removingdefined(HAVE_BACKTRACE_SYMBOLS) after Victor told me thatbacktrace_symbols wasn't used.

@vstinner
Copy link
Member

faulthandler is built as a built-in module, since Py_FatalError() uses it (dump the backtrace and than turns off faulthandler).

@picnixz
Copy link
MemberAuthor

I found the issue. Because ofAC_CHECK_HEADERS +AC_CHECK_FUNCS, we actually expandLDFLAGS 2x3=6 times, hence the 6-ldl -ldl -ldl -ldl -ldl -ldl.

@picnixz
Copy link
MemberAuthor

picnixz commentedApr 28, 2025
edited
Loading

PR is ready:#133071.

It doesn't look like GCC is complaining... but I think dl might be linked. 🤣

And yes, that's why I didn't see the warnings. I use gcc and not clang

@ZeroIntensity
Copy link
Member

I was wondering if autoreconf was smart enough to deal with the extra flags. Buildbots passed so I figured it was ok :(.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@gpsheadgpsheadgpshead approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@vstinnervstinnerAwaiting requested review from vstinner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@picnixz@bedevere-bot@freakboy3742@vstinner@ZeroIntensity@gpshead

[8]ページ先頭

©2009-2025 Movatter.jp