Movatterモバイル変換

corona10 added2 commits

April 27, 2025 18:47

tmp

6ca1abb

Use resize_copy as fallback logic

7618a2b

corona10 changed the title~~Kumar test~~gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject

corona10 removed the DO-NOT-MERGE label

bedevere-appbot mentioned this pull request

data race when resizing unicode objects#132070

Closed

corona10 added the skip news label

corona10 requested review fromcolesbury andkumaraditya303

April 27, 2025 10:08

Copy link

MemberAuthor

corona10 commentedApr 27, 2025•
edited
Loading

@kumaraditya303 @colesbury
I continued working on Kumar's PR#132091. In the new change, more states of unicode_modifiable are observed in free-threading builds. So I added a fallback to use resize_copy when unicode_modifiable fails, but I'm not sure if this is the right approach.
But the test failure issues are resolved.

corona10 marked this pull request as ready for review

April 27, 2025 10:12

bedevere-appbot added the awaiting core review label

corona10 added topic-free-threading needs backport to 3.13bugs and security fixes labels

corona10 changed the title~~gh-132070: use _PyObject_IsUniquelyReferenced in unicodeobject~~gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject

serhiy-storchaka reviewed

View reviewed changes

Objects/unicodeobject.c OutdatedShow resolvedHide resolved

Update Objects/unicodeobject.c

2750016

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

corona10 requested a review fromserhiy-storchaka

April 28, 2025 10:11

serhiy-storchaka approved these changes

View reviewed changes

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

bedevere-appbot added awaiting merge and removed awaiting core review labels

colesbury approved these changes

View reviewed changes

Copy link

Contributor

colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I looked into the case that requiresresize_copy: We have anio.StringIO, which is used first by one thread and then by a second thread. (It's not used by two threads simultaneously). Theio.StringIO has the only reference to aPyUnicodeWriter, which in turn has the only reference to unicode object that is treated as a buffer.

The_PyObject_IsUniquelyReferenced() check is too conservative in this case because the unicode object is owned by a different thread. The unicode object is actually safe to modify, we just can't tell that from_PyObject_IsUniquelyReferenced().

corona10 merged commit75cbb8d intopython:main

45 checks passed

Copy link

miss-islington-appbot commentedApr 29, 2025

Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject (p…

4f40bf2

…ythongh-133039)---------(cherry picked from commit75cbb8d)Co-authored-by: Donghee Na <donghee.na@python.org>Co-authored-by: Kumar Aditya <kumaraditya@python.org>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Copy link

bedevere-appbot commentedApr 29, 2025

GH-133121 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

corona10 deleted the kumar-test branch

April 29, 2025 02:07

Copy link

bedevere-appbot commentedApr 29, 2025

GH-133126 is a backport of this pull request to the3.13 branch.

corona10 added a commit that referenced this pull request

[3.13]gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject (…

7ffef8d

…gh-133039) (gh-133126)*gh-132070: Use _PyObject_IsUniquelyReferenced in unicodeobject (gh-133039)---------(cherry picked from commit75cbb8d)Co-authored-by: Donghee Na <donghee.na@python.org>Co-authored-by: Kumar Aditya <kumaraditya@python.org>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>* Add _PyObject_IsUniquelyReferenced---------Co-authored-by: Kumar Aditya <kumaraditya@python.org>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

corona10 mentioned this pull request