Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130197: Fix (and test) option inpygettext#133021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
StanFromIreland wants to merge5 commits intopython:main
base:main
Choose a base branch
Loading
fromStanFromIreland:pygettext-skip-doctstrings

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedApr 26, 2025•
edited by bedevere-appbot
Loading

This also required some updating of the snapshot testing logic to handle multiple files. This function should get more testing and I will come back to this once I complete more research. For now I fixed (and tested) what was implemented.

@StanFromIreland
Copy link
ContributorAuthor

Request@tomasr8@serhiy-storchaka

@tomasr8tomasr8 self-requested a reviewApril 26, 2025 18:48
@StanFromIreland
Copy link
ContributorAuthor

StanFromIreland commentedApr 26, 2025•
edited
Loading

Also, can we rename it toskip-docstrings since it just make so much more sense. (There so be no backwards compatibility concerns since the current option dosen't work anyway)

edit: Tommorow I’ll update the PR renaming it to exclude-docstrings

edit2: It has now been renamed toexclude-docstrings. This is much clearer (and consistent) that the option needs to be passed something, and is less conflicting with--docstrings.

@tomasr8
Copy link
Member

ok if we're gonna go with fnmatch, I'd also update the docs for the option to mention that fnmatch-style patterns are supported. I'd also add more tests for wildcards and directories.

@StanFromIreland
Copy link
ContributorAuthor

ok if we're gonna go with fnmatch, I'd also update the docs for the option to mention that fnmatch-style patterns are supported. I'd also add more tests for wildcards and directories.

Do we want this though? I guess we can, but should we.

@tomasr8tomasr8 self-requested a reviewMay 1, 2025 17:14
@StanFromIreland
Copy link
ContributorAuthor

Friendly ping@serhiy-storchaka

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8Awaiting requested review from tomasr8

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@StanFromIreland@tomasr8
[8]ページ先頭
©2009-2025 Movatter.jp