Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.13] Revert "[3.13] gh-132921: Fix setuptools._distutils.dep_util deprecation (GH-132923) (#132926)"#133004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:3.13fromvstinner:revert
Apr 26, 2025

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedApr 26, 2025
edited by bedevere-appbot
Loading

This reverts commit3776ade.

setuptools.modified module is not available on old setuptools versions.

…precation (pythonGH-132923) (python#132926)"This reverts commit3776ade.setuptools.modified module is not available on old setuptoolsversions.
@vstinner
Copy link
MemberAuthor

Python 3.13 uses setuptools-67.6.1 which doesn't havesetuptools.modified module yet :-(

@vstinnervstinner changed the titleRevert "[3.13] gh-132921: Fix setuptools._distutils.dep_util deprecation (GH-132923) (#132926)"[3.13] Revert "[3.13] gh-132921: Fix setuptools._distutils.dep_util deprecation (GH-132923) (#132926)"Apr 26, 2025
@vstinnervstinnerenabled auto-merge (squash)April 26, 2025 12:31
@vstinnervstinner merged commit994529d intopython:3.13Apr 26, 2025
46 checks passed
@vstinnervstinner deleted the revert branchApril 26, 2025 12:53
@kulikjak
Copy link
Contributor

Hi@vstinner, do you plan to backport this change in a different way? Because whilesetuptools.modified is not available in setuptools delivered with Python 3.13, the deprecation warning reappears when newer setuptools is available :(.

Internally, I went with the following; it should work with both old and new:

--- Python-3.13.3/Tools/peg_generator/pegen/build.py+++ Python-3.13.3/Tools/peg_generator/pegen/build.py@@ -95,7 +95,10 @@ def compile_c_extension(     import setuptools.logging      from setuptools import Extension, Distribution-    from setuptools._distutils.dep_util import newer_group+    try:+        from setuptools.modified import newer_group+    except ImportError:+        from setuptools._distutils.dep_util import newer_group     from setuptools._distutils.ccompiler import new_compiler     from setuptools._distutils.sysconfig import customize_compiler

@vstinner
Copy link
MemberAuthor

@kulikjak: I created a PR from your comment:#133522

kulikjak reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vstinner@kulikjak

[8]ページ先頭

©2009-2025 Movatter.jp