Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-87859: Track Code Object Local Kinds For Arguments#132980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-87859: Track Code Object Local Kinds For Arguments#132980
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Python/assemble.c Outdated
| PyErr_NoMemory(); | ||
| return ERROR; | ||
| } | ||
| int numargvars = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would it be possible to move this new code to afterkinds was calculated, and then you don't need to allocate theargkinds array (just modify thekinds array)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think I can make that work without slowing things down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
We should add a test for the new flags. |
219d8d2 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Doing this was always the intention. I was finally motivated to find the time to do it.
See#87859 (comment).