Apr 25, 2025 · May 22, 2025 · May 11, 2025 · May 11, 2025 · May 18, 2025
diff --git a/Lib/html/parser.py b/Lib/html/parser.py
                if match:
                    # match.group() will contain at least 2 chars
                    if end and match.group() == rawdata[i:]:
                        k = match.end()
                        if k <= i:
                            k = n
                        i = self.updatepos(i, i + 1)
                    # incomplete
                    break
Original file line number	Diff line number	Diff line change
Expand Up		@@ -244,9 +244,6 @@ def goahead(self, end):
		if match:
Copy link Member ezio-melottiMay 11, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Are there tests for this branch? Can you elaborate on when this branch is executed, and possibly add a test that ensures that the position just needs to be updated to`i + 1` and not`k`? Copy link Author muglugMay 11, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I have no idea what the ideal code should be — this is already an edge-case, that in a previous strict mode caused the parsing to fail. This un-executed code was addedin 2010 — maybe@bitdancer has more context (though I can hardly remember what I did last month, let alone answer for code I wrote 15 years ago). My general rule in these things is to clear up code so it matches what executes in production, and remove things that might trip up someone debugging the code into thinking the codedid something. Copy link Member bitdancerMay 18, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. No surprise, I have no memory of this. Looking at the original diff I don't see that that if on k was doing anything, and certainly in the current code it isn't doing anything. k doesn't have a meaningful value at that point, and isn't used. muglug reacted with thumbs up emoji
		# match.group() will contain at least 2 chars
		if end and match.group() == rawdata[i:]:
		k = match.end()
		if k <= i:
		k = n
		i = self.updatepos(i, i + 1)
		# incomplete
		break
Expand Down