Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify HTMLParser by removing unnecessary assignment and assertion#132972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
muglug wants to merge2 commits intopython:main
base:main
Choose a base branch
Loading
frommuglug:htmlparser-simplify

Conversation

muglug
Copy link

@muglugmuglug commentedApr 25, 2025
edited
Loading

The assignment tok is never used, because the block breaks.

Unused assignment originally introduced inb579dba

@python-cla-bot
Copy link

python-cla-botbot commentedApr 25, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@@ -226,9 +226,6 @@ def goahead(self, end):
if match:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are there tests for this branch?
Can you elaborate on when this branch is executed, and possibly add a test that ensures that the position just needs to be updated toi + 1 and notk?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have no idea what the ideal code should be — this is already an edge-case, that in a previous strict mode caused the parsing to fail.

This un-executed code was addedin 2010 — maybe@bitdancer has more context (though I can hardly remember what I did last month, let alone answer for code I wrote 15 years ago).

My general rule in these things is to clear up code so it matches what executes in production, and remove things that might trip up someone debugging the code into thinking the codedid something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No surprise, I have no memory of this. Looking at the original diff I don't see that that if on k was doing anything, and certainly in the current code it isn't doing anything. k doesn't have a meaningful value at that point, and isn't used.

muglug reacted with thumbs up emoji
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bitdancerbitdancerbitdancer left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@ezio-melottiezio-melottiezio-melotti left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@muglug@bitdancer@serhiy-storchaka@ezio-melotti

[8]ページ先頭

©2009-2025 Movatter.jp