Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Simplify HTMLParser by removing unnecessary assignment and assertion#132972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
python-cla-botbot commentedApr 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.
@@ -226,9 +226,6 @@ def goahead(self, end): | |||
if match: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are there tests for this branch?
Can you elaborate on when this branch is executed, and possibly add a test that ensures that the position just needs to be updated toi + 1
and notk
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have no idea what the ideal code should be — this is already an edge-case, that in a previous strict mode caused the parsing to fail.
This un-executed code was addedin 2010 — maybe@bitdancer has more context (though I can hardly remember what I did last month, let alone answer for code I wrote 15 years ago).
My general rule in these things is to clear up code so it matches what executes in production, and remove things that might trip up someone debugging the code into thinking the codedid something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No surprise, I have no memory of this. Looking at the original diff I don't see that that if on k was doing anything, and certainly in the current code it isn't doing anything. k doesn't have a meaningful value at that point, and isn't used.
Uh oh!
There was an error while loading.Please reload this page.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.
The assignment to
k
is never used, because the block breaks.Unused assignment originally introduced inb579dba