Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove duplicate check for self.cdata_elem in HTMLParser#132944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
muglug wants to merge1 commit intopython:3.13frommuglug:patch-2

Conversation

muglug
Copy link

This was already checked in the line above.

This was already checked in the line above
@python-cla-bot
Copy link

python-cla-botbot commentedApr 25, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@picnixz
Copy link
Member

The PR should be open against main, not 3.13. Or is main not affected by this change? if this is the case, we won't backport it as it's a slight optimization rather than a bugfix (unless it was a forgotten backport)

@StanFromIreland
Copy link
Contributor

StanFromIreland commentedApr 25, 2025•
edited
Loading

Ah I didn't notice.
It affects main, this should be closed.

@picnixz
Copy link
Member

picnixz commentedApr 25, 2025•
edited
Loading

Ok, I just checked butmain is affected as well. I guess it's fine to remove a redundant check but please open a new PR against main instead (namely, checkout from main, apply your fix, and then open the PR against main instead against 3.13). It will be cleaner than rebasing this onto main.

muglug reacted with thumbs up emoji

@muglug
Copy link
Author

Re-opened againstmain here:#132972

@muglugmuglug deleted the patch-2 branchApril 25, 2025 20:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@muglug@picnixz@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp