Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132908: Add math.isnormal/issubnormal() functions#132935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

skirpichev
Copy link
Contributor

@skirpichevskirpichev commentedApr 25, 2025•
edited by github-actionsbot
Loading

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some cosmetic nits.

skirpichevand others added2 commitsApril 25, 2025 17:45
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

So, we have some known buildbots issues. I'll wait for it to be solved and then once it's ok for them, I'll merge it.

@skirpichev
Copy link
ContributorAuthor

Technically it's very trivial pr, yet I would appreciate a second look from someone.

Maybe we should be more vague andnot define in any way normal/subnormal meaning (i.e. not reference sys.float_info). (Or mention this as CPython implementation detail.) E.g. should all Python implementations support subnormals?

Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO the docs and implementation are fine, everything is explained well.

Copy link
ContributorAuthor

@skirpichevskirpichev left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we can replace "floating-point number" with just a "number" (as integers are automatically converted to floats)?

@skirpichev
Copy link
ContributorAuthor

CC@serhiy-storchaka per experts index. See also issue thread.

@serhiy-storchakaserhiy-storchaka changed the titlegh-132908: add math.normal/subnormal() functionsgh-132908: Add math.isnormal/issubnormal() functionsJun 2, 2025
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

skirpichev reacted with thumbs up emoji
@serhiy-storchakaserhiy-storchaka merged commit5f61cde intopython:mainJun 2, 2025
39 checks passed
@skirpichevskirpichev deleted the isnormal-subnormal/132908 branchJune 2, 2025 10:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@skirpichev@picnixz@serhiy-storchaka@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp