Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-132930: Implement PEP 773#132931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
gh-132930: Implement PEP 773#132931
Changes from1 commit
39c59509bd959ad5f2be2ff7c9be3f8b982d38fdee9156ec6e1304db45ba01447c5019603f958e2e8315c6b570ea2293c5828f8ffFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -20,32 +20,14 @@ def _not_empty(n, key=None): | ||
| return result | ||
| def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| TARGET = "python.exe" | ||
| TARGETW = "pythonw.exe" | ||
| SYS_ARCH = { | ||
| "win32": "32bit", | ||
| "amd64": "64bit", | ||
| "arm64": "64bit", # Unfortunate, but this is how it's spec'd | ||
| }[ns.arch] | ||
| TAG_ARCH = { | ||
| "win32": "-32", | ||
| @@ -75,11 +57,11 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| # Embeddable distro comes under a different Company | ||
| COMPANY = "PythonEmbed" | ||
| TARGETW = None | ||
| ALIAS_PREFIX = None | ||
| DISPLAY_TAGS.append("embeddable") | ||
| # Deliberately name the file differently from the existing distro | ||
| # so we can republish old versions without replacing files. | ||
| FILE_SUFFIX = f"-embeddable-{ns.arch}" | ||
| if ns.include_freethreaded: | ||
| # Free-threaded distro comes with a tag suffix | ||
| TAG_SUFFIX = "t" | ||
| @@ -92,11 +74,8 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| FULL_ARCH_TAG = f"{FULL_TAG}{TAG_ARCH}" | ||
| XY_TAG = f"{VER_MAJOR}.{VER_MINOR}{TAG_SUFFIX}" | ||
| XY_ARCH_TAG = f"{XY_TAG}{TAG_ARCH}" | ||
| X_TAG = f"{VER_MAJOR}{TAG_SUFFIX}" | ||
| X_ARCH_TAG = f"{X_TAG}{TAG_ARCH}" | ||
| # Tag used in runtime ID (for side-by-side install/updates) | ||
| ID_TAG = XY_ARCH_TAG | ||
| @@ -114,60 +93,57 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| STD_START = [] | ||
| STD_UNINSTALL = [] | ||
| # The list of 'py install <TAG>' tags that will match this runtime. | ||
| # Architecture should always be included here because PyManager will add it. | ||
| INSTALL_TAGS = [ | ||
| FULL_ARCH_TAG, | ||
| XY_ARCH_TAG, | ||
| X_ARCH_TAG, | ||
| # X_TAG and XY_TAG doesn't include VER_SUFFIX, so create -dev versions | ||
| f"{XY_TAG}-dev{TAG_ARCH}" if XY_TAG and VER_SUFFIX else "", | ||
| f"{X_TAG}-dev{TAG_ARCH}" if X_TAG and VER_SUFFIX else "", | ||
| ] | ||
| # Generate run-for entries for each target. | ||
| # Again, include architecture because PyManager will add it. | ||
| for base in [ | ||
| {"target": TARGET}, | ||
| {"target": TARGETW, "windowed": 1}, | ||
| ]: | ||
| if not base["target"]: | ||
| continue | ||
| STD_RUN_FOR.append({**base, "tag": FULL_ARCH_TAG}) | ||
| if XY_TAG: | ||
| STD_RUN_FOR.append({**base, "tag": XY_ARCH_TAG}) | ||
| if X_TAG: | ||
| STD_RUN_FOR.append({**base, "tag": X_ARCH_TAG}) | ||
| if VER_SUFFIX: | ||
| STD_RUN_FOR.extend([ | ||
| {**base, "tag": f"{XY_TAG}-dev{TAG_ARCH}" if XY_TAG else ""}, | ||
| {**base, "tag": f"{X_TAG}-dev{TAG_ARCH}" if X_TAG else ""}, | ||
| ]) | ||
| # Generate alias entries for each target. We need both arch and non-arch | ||
| # versions as well as windowed/non-windowed versions to make sure that all | ||
| # necessary aliases are created. | ||
| if ALIAS_PREFIX: | ||
| for prefix, base in [ | ||
| (ALIAS_PREFIX, {"target": TARGET}), | ||
| (f"{ALIAS_PREFIX}w", {"target": TARGETW, "windowed": 1}), | ||
| ]: | ||
| if not base["target"]: | ||
| continue | ||
| if XY_TAG: | ||
| STD_ALIAS.extend([ | ||
| {**base, "name": f"{prefix}{XY_TAG}.exe"}, | ||
| {**base, "name": f"{prefix}{XY_ARCH_TAG}.exe"}, | ||
| ]) | ||
| if X_TAG: | ||
| STD_ALIAS.extend([ | ||
| {**base, "name": f"{prefix}{X_TAG}.exe"}, | ||
| {**base, "name": f"{prefix}{X_ARCH_TAG}.exe"}, | ||
| ]) | ||
| STD_PEP514.append({ | ||
| "kind": "pep514", | ||
| "Key": rf"{COMPANY}\{ID_TAG}", | ||
| @@ -179,6 +155,7 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| "InstallPath": { | ||
| "_": "%PREFIX%", | ||
| "ExecutablePath": f"%PREFIX%{TARGET}", | ||
| # WindowedExecutablePath is added below | ||
| }, | ||
| "Help": { | ||
| "Online Python Documentation": { | ||
| @@ -202,9 +179,13 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| "IconIndex": 13, | ||
| "Target": f"https://docs.python.org/{VER_DOT}/", | ||
| }, | ||
| # IDLE and local documentation items are added below | ||
| ], | ||
| }) | ||
| if TARGETW: | ||
| STD_PEP514[0]["InstallPath"]["WindowedExecutablePath"] = f"%PREFIX%{TARGETW}" | ||
| if ns.include_idle: | ||
| STD_START[0]["Items"].append({ | ||
| "Name": f"IDLE {VER_DOT}{DISPLAY_SUFFIX}", | ||
| @@ -221,26 +202,23 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| "IconIndex": 0, | ||
| }) | ||
| if ns.include_html_doc: | ||
| STD_PEP514[0]["Help"]["Main Python Documentation"] = { | ||
| "_": rf"%PREFIX%Doc\html\index.html", | ||
| } | ||
| STD_START[0]["Items"].append({ | ||
| "Name": f"{DISPLAY_NAME} {VER_DOT} Manuals{DISPLAY_SUFFIX}", | ||
| "Target": r"%PREFIX%Doc\html\index.html", | ||
| }) | ||
| elif ns.include_chm: | ||
| STD_PEP514[0]["Help"]["Main Python Documentation"] = { | ||
| "_": rf"%PREFIX%Doc\{PYTHON_CHM_NAME}", | ||
| } | ||
| STD_START[0]["Items"].append({ | ||
| "Name": f"{DISPLAY_NAME} {VER_DOT} Manuals{DISPLAY_SUFFIX}", | ||
| "Target": "%WINDIR%hhc.exe", | ||
| "Arguments": rf"%PREFIX%Doc\{PYTHON_CHM_NAME}", | ||
| }) | ||
Comment on lines +213 to +221 Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I had thought we removed CHM ages ago? MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This script can be used to repackage releases a long way back, so it still has the support in there. Even though it lives in the repo alongside a particular version, it is pretty independent of the actual version it's laying out. | ||
| STD_UNINSTALL.append({ | ||
| "kind": "uninstall", | ||
| @@ -255,7 +233,7 @@ def calculate_install_json(ns, *, for_embed=False, for_test=False): | ||
| "sort-version": FULL_VERSION, | ||
| "company": COMPANY, | ||
| "tag": DISPLAY_TAG, | ||
| "install-for":_not_empty(INSTALL_TAGS), | ||
| "run-for": _not_empty(STD_RUN_FOR, "tag"), | ||
| "alias": _not_empty(STD_ALIAS, "name"), | ||
| "shortcuts": [ | ||