NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-122781: Fix`%z` in`strptime`#132922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pganssle merged 2 commits intopython:mainfromStanFromIreland:strptime-fix-z

May 20, 2025

Merged

gh-122781: Fix`%z` in`strptime`#132922

pganssle merged 2 commits intopython:mainfromStanFromIreland:strptime-fix-z

May 20, 2025

Conversation

Copy link

Contributor

StanFromIreland commentedApr 25, 2025•
edited
Loading

Alternate (simpler) approach than old pr:#122829 by just updating the regex (and testing it this time).

Issue:Behavior of datetime.datetime.strptime differs from documented behavior on %z #122781

commit

9a93927

StanFromIreland requested review frompganssle andabalkin ascode owners

April 25, 2025 10:51

bedevere-appbot added the awaiting review label

Apr 25, 2025

bedevere-appbot mentioned this pull request

Apr 25, 2025

Behavior of datetime.datetime.strptime differs from documented behavior on %z#122781

Closed

StanFromIreland mentioned this pull request

Apr 25, 2025

gh-122781: fix time format bug#122829

Open

Copy link

ContributorAuthor

StanFromIreland commentedApr 25, 2025

Test fails are unrelated.

pganssle requested changes

May 20, 2025

View reviewed changes

Copy link

Member

pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall good approach, just a nit about how to do the tests and also want to make sure%:z is covered as well.

Lib/test/datetimetester.py OutdatedShow resolvedHide resolved

bedevere-appbot added awaiting changes and removed awaiting review labels

May 20, 2025

Copy link

bedevere-appbot commentedMay 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.