Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132710: only use stable_uuid.generate_time_safe()
to deduce MAC address#132901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
cc@zanieb |
Uh oh!
There was an error while loading.Please reload this page.
2d398c9
to99bdd52
Compare99bdd52
toee71d62
CompareUh oh!
There was an error while loading.Please reload this page.
picnixz commentedApr 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@zanieb Does it actually solve your issue? becausemy system also appears to be unable to get the MAC address... but I was offline (I work offline during the week in general) and I didn't check when I'm online. |
It's kind of hard to test because I haven't added support for the latest 3.14 in |
zanieb commentedApr 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Okay, the patch does apply cleanly to the previous 3.14 alpha so I can test this. On macOS, it does resolve the problem. I did not test Linux. |
I tested a Linux build atastral-sh/python-build-standalone#595 (comment) and it didn't seem to work. |
Hum. It's very strange. Did I mess the configure script? what's the value of |
Looking at the logs... |
... so it's not |
zanieb commentedApr 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The builds are attached there if you want to hop into a debugger. Briefly... yeah it looks like it's called and we try each getter until we reach the random one:
|
So, the patch worked but it turns out |
Maybe we should add all possible |
We did try |
I suggest adding a print in the |
Those commands are just not installed by default in the |
picnixz commentedApr 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ha! so that's why. Let's also fix this by adding them as a dependency then |
bedevere-bot commentedApr 26, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commit16200ae 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132901%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
Ok the refleaks were fixed in#132989. |
Ok, it's actually a real bug fix because the docs say:
|
bedevere-bot commentedMay 17, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commite311181 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132901%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
bedevere-bot commentedMay 17, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commit19c6262 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132901%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
picnixz commentedMay 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@brettcannon is the configure issue a known WASM/WASI issue or is this an issue on my side, namely:
|
Uh oh!
There was an error while loading.Please reload this page.
libuuid
#132710