Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-63882: Implement sometest_minidom tests#132879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 6 commits intopython:mainfromStanFromIreland:apply-patch
Apr 26, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedApr 24, 2025•
edited by bedevere-appbot
Loading

@bedevere-appbedevere-appbot added awaiting review testsTests in the Lib/test dir labelsApr 24, 2025
@hugovk
Copy link
Member

Please include the original patch author in a Co-authored-by trailer.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors

StanFromIreland reacted with thumbs up emoji

StanFromIrelandand others added2 commitsApril 24, 2025 16:45
Co-authored-by: Julian Gindi <julian@gindi.io>
@StanFromIreland

This comment was marked as resolved.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've added some comments concerningunlink but AFAIK, this is only used to break internal references within the DOM itself. Since the objects are either discarded at the end of the function or are small, you might also forget about calling.unlink. OTOH, we can be consistent with the existing tests and always callunlink in anaddCleanup instead.

StanFromIrelandand others added2 commitsApril 25, 2025 15:53
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks

StanFromIreland reacted with heart emoji
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but I have a question.

@StanFromIreland
Copy link
ContributorAuthor

Question has been resolved.

@picnixzpicnixz self-assigned thisApr 26, 2025
@picnixz
Copy link
Member

@hugovk I'll actually let you write the commit message as I don't know how you want the original patch's author to be credited.

StanFromIreland reacted with thumbs up emoji

@picnixzpicnixz removed their assignmentApr 26, 2025
@hugovkhugovk merged commitee033d4 intopython:mainApr 26, 2025
38 checks passed
@hugovk
Copy link
Member

Thanks, just to make sure the Co-authored-by was in the commit description.

StanFromIreland reacted with thumbs up emoji

@hugovkhugovk added the needs backport to 3.13bugs and security fixes labelApr 26, 2025
@miss-islington-app
Copy link

Thanks@StanFromIreland for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 26, 2025
(cherry picked from commitee033d4)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Julian Gindi <julian@gindi.io>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

GH-133029 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 26, 2025
@StanFromIrelandStanFromIreland deleted the apply-patch branchApril 26, 2025 20:07
@StanFromIreland
Copy link
ContributorAuthor

It should have been auto populated by gh I believe?

hugovk added a commit that referenced this pull requestApr 26, 2025
…3029)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Julian Gindi <julian@gindi.io>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotiOS ARM64 Simulator 3.13 (tier-3) has failed when building commitfdcaaad.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1386/builds/1246) and take a look at the build logs.
  4. Check if the failure is related to this commit (fdcaaad) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1386/builds/1246

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/threading.py", line1041, in_bootstrap_innerself.run()~~~~~~~~^^  File"/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/threading.py", line992, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/test/test_interpreters/test_stress.py", line47, inrun    interp= interpreters.create()  File"/Users/buildbot/Library/Developer/XCTestDevices/E06CC346-3BDC-41D4-B51D-C70ADBC67E86/data/Containers/Bundle/Application/3439A6D5-E051-44C2-BFBB-1AD159C2D958/iOSTestbed.app/python/lib/python3.13/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

@StanFromIreland
Copy link
ContributorAuthor

Unrelated fail.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@StanFromIreland@hugovk@picnixz@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp