Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.13] Use os.openpty() instead of pty.openpty() in test_ioctl#132878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pty.openpty() does not work on Android, and it is easier to checkavailability of os.openpty.
!buildbot Android |
bedevere-bot commentedApr 24, 2025
🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commitaf45ba0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132878%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
It is weird that only 3.13 fails. I am going to apply the same change to main after testing it for 3.13. There is no benefit of using pty.openpty() over os.openpty(), because the tests fail if os.openpty() does not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
But it's kind of unusual to make a change first in 3.13, and then forward-port it to the main branch. I would suggest to start on main and then backport.
This is because the issue can only be reproduced in 3.13, so it is not possible to test the solution in main. |
bf6c74d intopython:3.13Uh oh!
There was an error while loading.Please reload this page.
pty.openpty() does not work on Android, and it is easier to check availability of os.openpty.