Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-93696: Fixed the breakpoint display error for frozen modules#132862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Lib/test/test_pdb.py Outdated
| self.assertIn('x = "Sentinel string for gh-93696"', stdout, "Sentinel statement not found") | ||
| self.assertIn('4 B', stdout, "breakpoint not found") | ||
| self.assertIn('-> def func():', stdout, "stack entry not found") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These two tests look identical as l. Make a loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point! I used loop for it.
eef49c3 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
#93697 attempted to extract the actual file of a frozen module, but it only did it for
list, notlonglistorwhere. With#131638, we can get source code of frozen modules without any extra efforts, so we should remove this piece of code now.Also, this code introduced a small error - it does not show breakpoints correctly. When we set breakpoints, we use the
co_filename(<frozen XXX>) as the key. Breakpoints can't be found if the filename is converted to real file, so theBindicator will not be there.Some extra tests were added.