Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131798: JIT: Split CALL_TUPLE_1 into several uops#132851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (sym_matches_type(arg, &PyTuple_Type)) { | ||
| // e.g. tuple((1, 2)) or tuple(foo) where foo is known to be a tuple | ||
| res = arg; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same optimization as in#132849 (comment)
| x = 0 | ||
| for _ in range(n): | ||
| y = tuple((1, 2)) # tuple argument | ||
| a, _ = y # _UNPACK_SEQUENCE_TWO_TUPLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I needed to useUNPACK_SEQUENCE(_TWO)_TUPLE here since it is currently the only uop that propagates the tuple items to the result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice observation. Seems like_BINARY_OP_SUBSCR_TUPLE_INT could be taught how to do this pretty easily for a constant RHS. Want to add that to your queue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's already in the queue 😄
08e3389 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
CALL_TUPLE_1is equivalent totuple(...).Very similar to previous work on splitting up
CALL_TYPE_1:#132419This splits the instruction into a smaller instruction + 2 guards which can be optimized away. This also sets the return type to
tuple.