Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132798: Schedule removal ofPyUnicode_AsDecoded/Encoded functions for 3.15#132799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 5 commits intopython:mainfromStanFromIreland:removal-schedule
Apr 25, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIrelandStanFromIreland commentedApr 22, 2025•
edited by github-actionsbot
Loading

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These functions are in the limited API. I'm not sure what the procedure is for removing them, but they can't just disappear from the ABI. Ithink the practice is to remove them from headers when the limited API isn't used. We should probably make note of that somewhere.

@vstinner
Copy link
Member

These functions are in the limited API. I'm not sure what the procedure is for removing them

Mark them asabi_only inMisc/stable_abi.toml, keep their implementation, and usePyAPI_FUNC() in the C file.

See PyUnicode_GetSize() for an existing example.

ZeroIntensity and StanFromIreland reacted with thumbs up emoji

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@StanFromIreland
Copy link
ContributorAuthor

Anything else left to do@vstinner ?

Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@vstinnervstinner merged commitf6fb498 intopython:mainApr 25, 2025
42 checks passed
@StanFromIrelandStanFromIreland deleted the removal-schedule branchApril 25, 2025 13:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@vstinnervstinnervstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@StanFromIreland@vstinner@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp