Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132796: Closes SMTP connection on 421 during data in sendmail#132797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
gh-132796: Closes SMTP connection on 421 during data in sendmail#132797
Conversation
Fixes a minor issue in smtlib.SMTP.sendmail that leads to SMTP client connections not being closed when a server responds with 421 during a DATA command. The existing 421 handling covers almost all cases, but as the DATA command method already handles some error response codes, the 421 is masked for sendmail.
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This comment was marked as duplicate.
This comment was marked as duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry for the delay on reviews. Per the bot, let's add a blurb entry.
No worries, thanks for taking the time! I have just added the NEWS entry. |
Uh oh!
There was an error while loading.Please reload this page.
Fixes a minor issue in smtlib.SMTP.sendmail that leads to SMTP client connections not being closed when a server responds with 421 during a DATA command. The existing 421 handling covers almost all cases, but as the DATA command method already handles some error response codes, the 421 is masked for sendmail.