Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132742: Improve tests for fcntl.ioctl()#132791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 9 commits intopython:mainfromserhiy-storchaka:test-ioctl2
Apr 28, 2025

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedApr 22, 2025•
edited
Loading

  • Do not skip ALL ioctl() tests when /dev/tty is not available.Done in other PR.
  • Use better tests for integer argument.
  • Add also parallel tests for tcflush() and tcflow().

* Do not skip ALL ioctl() tests when /dev/tty is not available.* Use better tests for integer argument.* Add also parallel tests for tcflush() and tcflow().
@bedevere-appbedevere-appbot added awaiting core review testsTests in the Lib/test dir labelsApr 22, 2025
@bedevere-appbedevere-appbot mentioned this pull requestApr 22, 2025
@serhiy-storchaka
Copy link
MemberAuthor

For some reasonstcflush() andtcflow() work differently on Linux/OpenIndiana vs BSD/macOS.

@serhiy-storchakaserhiy-storchaka marked this pull request as ready for reviewApril 24, 2025 09:57
@serhiy-storchakaserhiy-storchaka added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 24, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@serhiy-storchaka for commit7efcbf9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132791%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 24, 2025
Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good

@serhiy-storchakaserhiy-storchaka merged commited8e886 intopython:mainApr 28, 2025
42 checks passed
@serhiy-storchakaserhiy-storchaka deleted the test-ioctl2 branchApril 28, 2025 07:42
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.13bugs and security fixes labelApr 28, 2025
@miss-islington-app
Copy link

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker ed8e886f4f59df4eceefeb7eef2e3d146967df34 3.13

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestApr 28, 2025
)* Use better tests for integer argument.* Add also parallel tests for tcflush() and tcflow().(cherry picked from commited8e886)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-133066 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 28, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Android 3.x (tier-3) has failed when building commited8e886.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/2107) and take a look at the build logs.
  4. Check if the failure is related to this commit (ed8e886) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/2107

Failed tests:

  • test_ioctl
  • test_termios

Failed subtests:

  • test_tcflush_clear_input_or_output - test.test_termios.TestFunctions.test_tcflush_clear_input_or_output
  • test_ioctl_clear_input_or_output - test.test_ioctl.IoctlTestsPty.test_ioctl_clear_input_or_output

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line173, intest_tcflush_clear_input_or_outputself.assertEqual(os.read(rfd,1024),b'ABCDEF')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:b'ef' != b'ABCDEF'Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line173, intest_tcflush_clear_input_or_outputself.assertEqual(os.read(rfd,1024),b'ABCDEF')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:b'efABCDEF' != b'ABCDEF'Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_ioctl.py", line164, intest_ioctl_clear_input_or_outputself.assertEqual(os.read(rfd,1024),b'ABCDEF')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:b'ef' != b'ABCDEF'

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Android 3.x (tier-3) has failed when building commited8e886.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1591/builds/1933) and take a look at the build logs.
  4. Check if the failure is related to this commit (ed8e886) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1591/builds/1933

Failed tests:

  • test_ioctl
  • test_termios

Failed subtests:

  • test_tcflush_clear_input_or_output - test.test_termios.TestFunctions.test_tcflush_clear_input_or_output
  • test_ioctl_clear_input_or_output - test.test_ioctl.IoctlTestsPty.test_ioctl_clear_input_or_output

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line173, intest_tcflush_clear_input_or_outputself.assertEqual(os.read(rfd,1024),b'ABCDEF')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:b'ef' != b'ABCDEF'Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line173, intest_tcflush_clear_input_or_outputself.assertEqual(os.read(rfd,1024),b'ABCDEF')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:b'efABCDEF' != b'ABCDEF'Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_ioctl.py", line164, intest_ioctl_clear_input_or_outputself.assertEqual(os.read(rfd,1024),b'ABCDEF')~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:b'ef' != b'ABCDEF'

serhiy-storchaka added a commit that referenced this pull requestApr 28, 2025
)* Use better tests for integer argument.* Add also parallel tests for tcflush() and tcflow().(cherry picked from commited8e886)
@serhiy-storchaka
Copy link
MemberAuthor

#133070 should fix the newly added tests on Android.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 RHEL8 LTO 3.x (tier-2) has failed when building commited8e886.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/338/builds/8637) and take a look at the build logs.
  4. Check if the failure is related to this commit (ed8e886) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/338/builds/8637

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line1079, in_bootstrap_innerself._context.run(self.run)~~~~~~~~~~~~~~~~~^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line1021, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line47, inrun    interp= interpreters.create()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedkTraceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line1079, in_bootstrap_innerself._context.run(self.run)~~~~~~~~~~~~~~~~~^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/threading.py", line1021, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line30, intask    interp= interpreters.create()  File"/home/buildbot/buildarea/3.x.cstratak-RHEL8-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

@vstinner
Copy link
Member

There are failures on "AMD64 Android 3.x" buildbot:https://buildbot.python.org/#/builders/1591/builds/1936

FAIL: test_ioctl_clear_input_or_output (test.test_ioctl.IoctlTestsPty.test_ioctl_clear_input_or_output)----------------------------------------------------------------------Traceback (most recent call last):  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_ioctl.py", line 164, in test_ioctl_clear_input_or_output    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: b'ef' != b'ABCDEF'FAIL: test_tcflush_clear_input_or_output (test.test_termios.TestFunctions.test_tcflush_clear_input_or_output)----------------------------------------------------------------------Traceback (most recent call last):  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_termios.py", line 173, in test_tcflush_clear_input_or_output    self.assertEqual(os.read(rfd, 1024), b'ABCDEF')    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: b'ef' != b'ABCDEF'

@serhiy-storchaka:

#133070 should fix the newly added tests on Android.

Aha, let me see.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead approved these changes

@auvipyauvipyauvipy approved these changes

Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@serhiy-storchaka@bedevere-bot@vstinner@gpshead@auvipy
[8]ページ先頭
©2009-2025 Movatter.jp