Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-105895: Addmatch andcase tohelp topics#132784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
python-cla-botbot commentedApr 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I'm not sure if I should also commit the autogenerated |
dzherb commentedApr 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This test case fails not due to unsorted keywords, but because classTestHelper(unittest.TestCase):deftest_keywords(self):self.assertEqual(sorted(pydoc.Helper.keywords),sorted(keyword.kwlist)) I suggest splitting this into two separate cases: classTestHelper(unittest.TestCase):deftest_keywords_are_sorted(self):self.assertEqual(sorted(pydoc.Helper.keywords),list(pydoc.Helper.keywords), )deftest_keywords_in_grammar(self):all_keywords=set(keyword.kwlist)|set(keyword.softkwlist)forkwinpydoc.Helper.keywords:self.assertIn(kw,all_keywords) |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I checked out this PR and tried:
I think that you need to regenpydoc-topics with:make -C Doc pydoc-topics
It might take a while.
Also, add a NEWS entry (see#132784 (comment) about how to do that) and change the issue number :) I will update you PR title for you to match the original issue#132783
match andcase tohelp topicsmatch andcase tohelp topicsMost changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Uh oh!
There was an error while loading.Please reload this page.
# Conflicts:#Lib/pydoc_data/topics.py
@sobolevn could you please look at the last changes? Is everything ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, but I can't merge this PR. Since I am not an expert inpydoc and I need someone who knows how it actually works to verify :)
Uh oh!
There was an error while loading.Please reload this page.
helpseems to have no information onmatchorcase#105895📚 Documentation preview 📚:https://cpython-previews--132784.org.readthedocs.build/
helpseems to have no information onmatchorcase#105895