Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-127081: use re-entrant variants ofget{proto,serv}by{name,port}#132750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
duaneg wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromduaneg:gh-127081-socket

Conversation

duaneg
Copy link
Contributor

@duanegduaneg commentedApr 20, 2025
edited by bedevere-appbot
Loading

Add configure tests and defines for getservbyname_r, getservbyport_r, and getprotobyname_r. Use these if available, otherwise fallback to the thread-unsafe variants.

Add a unit test to exercise getprotobyname, which is currently untested.

TODO:

  • Are there any platforms which define the unsafe variants but not the re-entrant ones? If not we can simplify the #ifdef hell somewhat.
  • Do the re-entrant functions have the same signature on all platforms?
  • These changes follow the existing code's practice: allocate a fixed-size (and overly large) buffer, and don't properly handle the error case if it is too small. Should this be fixed? If so should existing code also be fixed?

Add configure tests and defines for getservbyname_r, getservbyport_r, andgetprotobyname_r. Use these if available, otherwise fallback to thethread-unsafe variants.Add a unit test to exercise getprotobyname, which is currently untested.TODO: - Are there any platforms which define the unsafe variants but not the   re-entrant ones? If not we can simplify the #ifdef hell somewhat. - Do the re-entrant functions have the same signature on all platforms? - These changes follow the existing code's practice: allocate a fixed-size   (and overly large) buffer, and don't properly handle the error case if it is   too small. Should this be fixed? If so should existing code also be fixed?
@picnixzpicnixz changed the titlegh-127081: use re-entrant variants of get{proto,serv}by{name,port}gh-127081: use re-entrant variants ofget{proto,serv}by{name,port}Apr 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@duaneg

[8]ページ先頭

©2009-2025 Movatter.jp