Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132744: Check recursion limit in _PY_FRAME_GENERAL#132746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 6 commits intopython:mainfromFidget-Spinner:fix_recursion
May 2, 2025

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commentedApr 20, 2025•
edited by bedevere-appbot
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedApr 20, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@markshannon
Copy link
Member

Would it be better to add the_CHECK_STACK_SPACE micro-op to theCALL_PY_GENERAL andCALL_BOUND_METHOD_GENERAL macro instructions?

@Fidget-Spinner
Copy link
MemberAuthor

Would it be better to add the_CHECK_STACK_SPACE micro-op to theCALL_PY_GENERAL andCALL_BOUND_METHOD_GENERAL macro instructions?

Done.

@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commentedApr 29, 2025•
edited
Loading

Actually, those two instructions don't need to check stack space (they use the frame push that can fail, instead of the one that pushes without checks), they only need to check recursion remaining. So I split it into another uop to make things more efficient.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks

@markshannonmarkshannon merged commitddac7ac intopython:mainMay 2, 2025
64 checks passed
@Fidget-SpinnerFidget-Spinner deleted the fix_recursion branchMay 2, 2025 17:08
@markshannonmarkshannon added the needs backport to 3.13bugs and security fixes labelMay 5, 2025
@miss-islington-app
Copy link

Thanks@Fidget-Spinner for the PR, and@markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@Fidget-Spinner and@markshannon, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker ddac7ac59a7dfa4437562b6e705e64865c3b1e9a 3.13

@serhiy-storchaka
Copy link
Member

Reminder about backporting.@Fidget-Spinner@markshannon

@bedevere-app
Copy link

GH-138032 is a backport of this pull request to the3.13 branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees

@markshannonmarkshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fidget-Spinner@markshannon@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp