NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

gh-132542: Set native thread ID after fork#132701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 5 commits intopython:mainfromnoamcohen97:fork-tid

May 20, 2025

Merged

gh-132542: Set native thread ID after fork#132701

serhiy-storchaka merged 5 commits intopython:mainfromnoamcohen97:fork-tid

May 20, 2025

Conversation

Copy link

Contributor

noamcohen97 commentedApr 18, 2025•
edited by bedevere-appbot
Loading

Since most of Python's runtime state, including thread-related data, is only consistent afterPyOS_AfterFork_Child() is called, updatingnative_id in theafter_fork handler ensures correctness and aligns with Python’s existing fork-handling mechanisms.

Issue:threading.Thread.native_id for forking thread wrong after fork #132542

Add test for native thread ID after fork

19b7d6c

bedevere-appbot added the awaiting review label

Apr 18, 2025

bedevere-appbot mentioned this pull request

Apr 18, 2025

threading.Thread.native_id for forking thread wrong after fork#132542

Closed

ZeroIntensity reviewed

Apr 19, 2025

View reviewed changes

Copy link

Member

ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs a blurb entry.

Lib/test/test_threading.py OutdatedShow resolvedHide resolved

noamcohen97 requested a review fromZeroIntensity

April 19, 2025 14:18

noamcohen97 added2 commits

April 19, 2025 17:27

Enhance test for native thread ID after fork to validate parent threa…

0115738

…d ID consistency

Add blurb entry

6ebd095

noamcohen97 force-pushed thefork-tid branch fromfa5bb79 to6ebd095Compare

April 19, 2025 14:27

ZeroIntensity added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Apr 19, 2025

Copy link

bedevere-bot commentedApr 19, 2025

🤖 New build scheduled with the buildbot fleet by@ZeroIntensity for commit6ebd095 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132701%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section label

Apr 19, 2025

ZeroIntensity approved these changes

Apr 20, 2025

View reviewed changes

Copy link

Member

ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

bedevere-appbot added awaiting core review and removed awaiting review labels

Apr 20, 2025

ZeroIntensity added the needs backport to 3.13bugs and security fixes label

Apr 20, 2025

gpshead reviewed

Apr 27, 2025

View reviewed changes

Lib/test/test_threading.py OutdatedShow resolvedHide resolved

serhiy-storchaka added the needs backport to 3.14bugs and security fixes label

May 8, 2025

noamcohen97 added2 commits

May 20, 2025 18:34

wait for child process in test

a7e5c51

Merge branch 'main' into fork-tid

d42f0de

noamcohen97 requested a review fromgpshead

May 20, 2025 15:58

serhiy-storchaka approved these changes

May 20, 2025

View reviewed changes

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍👍

bedevere-appbot added awaiting merge and removed awaiting core review labels

May 20, 2025

serhiy-storchakaenabled auto-merge (squash)

May 20, 2025 16:15

serhiy-storchaka merged commit6b73502 intopython:main

May 20, 2025

43 checks passed

bedevere-appbot removed the awaiting merge label

May 20, 2025

Copy link

miss-islington-appbot commentedMay 20, 2025

Thanks@noamcohen97 for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 20, 2025

pythongh-132542: Set native thread ID after fork (pythonGH-132701)

2b4359b

(cherry picked from commit6b73502)Co-authored-by: Noam Cohen <noam@noam.me>

Copy link

miss-islington-appbot commentedMay 20, 2025

Sorry,@noamcohen97 and@serhiy-storchaka, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 6b735023132a4ac9dc5b849d982104eeb1e8bdad 3.13

miss-islington-appbot assignedserhiy-storchaka

May 20, 2025

Copy link

bedevere-appbot commentedMay 20, 2025

GH-134356 is a backport of this pull request to the3.14 branch.

bedevere-appbot removed the needs backport to 3.14bugs and security fixes label

May 20, 2025

Copy link

bedevere-appbot commentedMay 20, 2025

GH-134361 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

May 20, 2025

serhiy-storchaka pushed a commit that referenced this pull request

May 20, 2025

[3.14]gh-132542: Set native thread ID after fork (GH-132701) (GH-134356

8e8d5c9

)(cherry picked from commit6b73502)Co-authored-by: Noam Cohen <noam@noam.me>

serhiy-storchaka pushed a commit that referenced this pull request

May 20, 2025

[3.13]gh-132542: Set native thread ID after fork (GH-132701) (GH-134361

aebbbaf

)(cherry picked from commit6b73502)

noamcohen97 deleted the fork-tid branch

May 20, 2025 17:31

Copy link

Contributor

kulikjak commentedMay 21, 2025•
edited
Loading

Hi, the newly added test fails on systems withoutnative_id:

Traceback (most recent call last):  File"<string>", line6, in<module>    parent_thread_native_id= threading.current_thread().native_id^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AttributeError:'_MainThread' object has no attribute 'native_id'

(whileLib/threading.py does check for its existence, the test does not)