Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132671: Do not match host+port with proxy bypass macOS rules, match host only.#132672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
nikola-sh wants to merge5 commits intopython:main
base:main
Choose a base branch
Loading
fromnikola-sh:patch-1

Conversation

nikola-sh
Copy link

@nikola-shnikola-sh commentedApr 18, 2025•
edited
Loading

maxim-krikun reacted with hooray emoji
…if URL contains portDo not match host+port with proxy bypass rules, match host only.Issuepython#132671
@python-cla-bot
Copy link

python-cla-botbot commentedApr 18, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@nikola-sh
Copy link
Author

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@ZeroIntensityZeroIntensity added the needs backport to 3.13bugs and security fixes labelApr 21, 2025
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a test and sign the CLA.

@@ -0,0 +1 @@
Fix issue where system proxy bypass configuration doesn't work with URL with port part.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

  • We need some context about what module/function is actually being fixed.
  • "system proxy bypass configuration doesn't work" is a bit wordy.
Suggested change
Fixissue where systemproxy bypassconfiguration doesn't workwithURL withportpart.
Fix proxy bypasson URLswithaportin:mod:`urllib.request`.

@nikola-sh
Copy link
Author

Please add a test and sign the CLA.

Hello!
CLA was already signed.
The test has been added.

@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

Assignees
No one assigned
Labels
awaiting core reviewneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@nikola-sh@ZeroIntensity@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp