Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130167: Improve the error case fortextwrap.dedent#132666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AA-Turner merged 5 commits intopython:mainfromAA-Turner:fix-textwrap-error
Apr 19, 2025

Conversation

AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commentedApr 18, 2025•
edited by bedevere-appbot
Loading

@hroncok
Copy link
Contributor

Would it be possible to add a test for this?

@hroncok
Copy link
Contributor

Thanks. I suppose bytes would still TypeError implicitly, right?

@AA-Turner
Copy link
MemberAuthor

Yes, but with an error message frombytes.split. I've pushed an improvement.

hroncok reacted with thumbs up emoji

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Out of curiosity, can we have the benchmarks for this change on empty strings? I don't think we lose much but I'm just curious.

@AA-Turner
Copy link
MemberAuthor

I won't have time in the near future to run benchmarks.

A

picnixz reacted with thumbs up emoji

@AA-TurnerAA-Turner merged commite7c5f60 intopython:mainApr 19, 2025
43 checks passed
@AA-TurnerAA-Turner deleted the fix-textwrap-error branchApril 19, 2025 15:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@AA-Turner@hroncok@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp