Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132661: Implement PEP 750#132662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lysnikolaou merged 104 commits intopython:mainfromlysnikolaou:tstrings
Apr 30, 2025
Merged

Conversation

lysnikolaou
Copy link
Member

@lysnikolaoulysnikolaou commentedApr 17, 2025•
edited by github-actionsbot
Loading

PEP 750 implementation! 🎉

Let's make sure as many people as possible take a look at this, since it's touching many areas that I've not worked on before.

📚 Documentation preview 📚:https://cpython-previews--132662.org.readthedocs.build/

vasily-v-ryabov reacted with thumbs up emojiAA-Turner, efimov-mikhail, hugovk, Object905, vitaldmit, agriyakhetarpal, nineteendo, erlend-aasland, and bswck reacted with hooray emojiAA-Turner, erlend-aasland, and bswck reacted with heart emojigitgernit, Wingysam, erlend-aasland, and bswck reacted with rocket emoji
lysnikolaouand others added30 commitsOctober 18, 2024 17:41
* Rename expr to expression, conv to conversion* Move templatelib under string lib* Add strings lib to LIBSUBDIRS* Update type of Template/TemplateIter/Interpolation
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@lysnikolaou
Copy link
MemberAuthor

Should we run buildbots one more time? They're weren't green when they were ran originally.

Yes, I'll run them again before merging, after I've pulledmain in. They weren't all green originally, but I've rerun them since then and they were green the second time (only one exception with an unrelated failure).

@sobolevn
Copy link
Member

Oh, I messed up, sorry. I clicked "merge main", but it was a long process :(

@lysnikolaou
Copy link
MemberAuthor

Oops, I was too late. 😆

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One question and LGTM.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not convinced about addingstring/templatelib.py instead of adding the new types totypes.
Either way, the C module is unnecessary.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@lysnikolaou
Copy link
MemberAuthor

@markshannon Thanks for the review! I've removed the_templatelib extension.

Regarding thetypes vsstring.templatelib discussion, I don't have a strong opinion either way, but it feels that it's too late for it to be reopened. The SC made their decision and I think we should go with it. We're a week away from the beta freeze and I'd like to get this PR in.

erlend-aasland reacted with thumbs up emoji

@sobolevn
Copy link
Member

In my humble opinion we should not add totypes what we can add to some other semantically named module.

@lysnikolaoulysnikolaou added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 29, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@lysnikolaou for commit0b1aef9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132662%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 29, 2025
@markshannon
Copy link
Member

@markshannon Thanks for the review! I've removed the_templatelib extension.

Regarding thetypes vsstring.templatelib discussion, I don't have a strong opinion either way, but it feels that it's too late for it to be reopened. The SC made their decision and I think we should go with it. We're a week away from the beta freeze and I'd like to get this PR in.

I'm fine with you merging this now. It is only a small change to move the code totypes.py in another PR if that's what we decide we want.

lysnikolaou reacted with thumbs up emoji

@markshannonmarkshannon self-requested a reviewApril 29, 2025 17:18
@lysnikolaoulysnikolaou merged commit6020260 intopython:mainApr 30, 2025
72 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@dylwil3dylwil3dylwil3 left review comments

@vasily-v-ryabovvasily-v-ryabovvasily-v-ryabov left review comments

@picnixzpicnixzpicnixz approved these changes

@markshannonmarkshannonmarkshannon approved these changes

@AA-TurnerAA-TurnerAA-Turner approved these changes

@pablogsalpablogsalpablogsal approved these changes

@brandtbucherbrandtbucherbrandtbucher approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@sobolevnsobolevnsobolevn approved these changes

@Eclips4Eclips4Eclips4 approved these changes

@hugovkhugovkhugovk approved these changes

@isidenticalisidenticalAwaiting requested review from isidenticalisidentical is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygoodAlexWaygood is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

20 participants
@lysnikolaou@Wingysam@hugovk@bedevere-bot@sobolevn@AA-Turner@ZeroIntensity@markshannon@JelleZijlstra@vasily-v-ryabov@picnixz@pablogsal@brandtbucher@dylwil3@Eclips4@StanFromIreland@koxudaxi@davepeck@terryjreedy@pauleveritt
[8]ページ先頭
©2009-2025 Movatter.jp