Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132629: Deprecate acception out of range values for unsigned integers in PyArg_Parse#132630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
gh-132629: Deprecate acception out of range values for unsigned integers in PyArg_Parse#132630
Conversation
… integers in PyArg_ParseFor unsigned integer formats in the PyArg_Parse* funcions,accepting Python integers with value that is larger thanthe maximal value the corresponding C type or less thanthe minimal value for the corresponding signed integer typeis now deprecated.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would it be possible to wait for Python 3.15 to introduce this new DeprecationWarning? I would prefer to avoid adding new warnings later in the 3.14 dev cycle.
I like the overall change :-)
This is not a blocker. But the sooner we add warnings, the sooner we can turn them into errors. Recently, you and me added many uses of unsigned integer converters in the socket addresses parsing code. This fixed errors, and allowed to pass values that exceed the limit of corresponding signed integer type, but made the new code more error prone, because passing value that exceeds the limit of an unsigned integer type does not lead to exception. This is the main reason I created that PR now. The idea I proposed a year ago:capi-workgroup/api-evolution#49. |
Doc/whatsnew/3.14.rst Outdated
| the maximal value the corresponding C type or less than | ||
| the minimal value for the corresponding signed integer type | ||
| is now deprecated. | ||
| (Contributed by Serhiy Storchaka in :gh:`132629`.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should move this entry to Doc/whatsnew/3.15.rst.
Tools/clinic/libclinic/converters.py Outdated
| @@ -161,12 +161,19 @@ def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> st | |||
| elif self.format_unit == 'B': | |||
| return self.format_code(""" | |||
| {{{{ | |||
| unsigned long ival = PyLong_AsUnsignedLongMask({argname}); | |||
| if (ival == (unsigned long)-1 && PyErr_Occurred()) {{{{ | |||
| Py_ssize_t _bytes = PyLong_AsNativeBytes({argname}, &{paramname}, sizeof(unsigned char), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you factorize this code? It's copied 4 times. For example, write a function which returns this template, with an argument: the sizeof() argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, it is not the exactly the same. Forunsigned long andunsigned long long it does additional check (historically).
But well, it can be factorized, and with recent changes in Argument Clinic, even more code can be factorized.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/C_API/2025-04-17-12-37-27.gh-issue-132629.01ArwX.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| @@ -3,7 +3,7 @@ | |||
| // Need limited C API version 3.13 for PyLong_AsInt() | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| // Need limited C API version 3.13 forPyLong_AsInt() | |
| // Need limited C API version 3.14 forPyLong_AsNativeBytes() in AC code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, event if I would prefer to also emit deprecation warnings for (any) negative value for unsigned types.
Co-authored-by: Victor Stinner <vstinner@python.org>
Uh oh!
There was an error while loading.Please reload this page.
For unsigned integer formats in the PyArg_Parse* funcions, accepting Python integers with value that is larger than the maximal value the corresponding C type or less than the minimal value for the corresponding signed integer type is now deprecated.
📚 Documentation preview 📚:https://cpython-previews--132630.org.readthedocs.build/