Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-100239: specialize BINARY_OP/SUBSCR for list-slice#132626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 9 commits intopython:mainfromiritkatriel:list_subscr
May 1, 2025

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedApr 17, 2025
edited by bedevere-appbot
Loading

@markshannon
Copy link
Member

markshannon commentedApr 17, 2025
edited
Loading

list_subscript/_PyList_Subscript is the general subscript function for lists. I think we want to use a more specialized function that only works for slices. i.e this code:https://github.com/python/cpython/blob/main/Objects/listobject.c#L3614-L3618

@markshannon
Copy link
Member

Thestats diff show a 50x increase in "subscr tuple slice" as a cause of specialization failure. Any idea why that might be? I can't see any reason for it.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good

@iritkatrieliritkatrielenabled auto-merge (squash)May 1, 2025 10:15
@iritkatrieliritkatriel merged commit5529213 intopython:mainMay 1, 2025
63 of 64 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@iritkatriel@markshannon

[8]ページ先頭

©2009-2025 Movatter.jp