Addresolve_host keyword-only argument tourl2pathname(), defaulting to false. When set to true, we callsocket.gethostbyname() to resolve the URL authority (netloc).

Issue:Path.from_uri() doesn't work if the URI contains host component #123599

pythonGH-123599:url2pathname(): don't callgethostbyname()by de…

0630a2d

…faultFollow-up to 0879ebc.Add *resolve_netloc* keyword-only argument to `url2pathname()`, defaultingto false. When set to true, we call `socket.gethostbyname()` to resolvethe URL authority (netloc).

bedevere-appbot mentioned this pull request

Apr 16, 2025

Path.from_uri() doesn't work if the URI contains host component#123599

Closed

barneygale added2 commits

April 16, 2025 20:25

Docs + tests fixes

26c8688

This is hard to explain D:

1bff8b9

barneygale marked this pull request as ready for review

April 16, 2025 19:58

bedevere-appbot added the awaiting core review label

Apr 16, 2025

barneygale requested review fromserhiy-storchaka,picnixz andAA-Turner

April 16, 2025 19:58

barneygale added2 commits

April 16, 2025 21:04

Terminology

4ec391f

Faffing

8df17b4

AA-Turner reviewed

Apr 17, 2025

View reviewed changes

Doc/library/urllib.request.rst OutdatedShow resolvedHide resolved

Lib/urllib/request.py OutdatedShow resolvedHide resolved

serhiy-storchaka reviewed

Apr 17, 2025

View reviewed changes

Lib/urllib/request.py

		@@ -1494,6 +1494,8 @@ def _is_local_authority(authority):
		if authority == hostname:
		return True
		# Compare IP addresses
		if not resolve:

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wonder, should we check this before callinggethostname() which can fail?

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm struggling to come up with firm info on whengethostname() fails (or whether it can perform network access). Do you have any pointers? Thanks.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I do not know.

But I was thinking about this case: processing the "file:" URL on different computer. We cannot usegethostname(), because it returns a different result. If we want to get a path onother computer, we should ignore the host name. There will still be problem with processing Windows paths on Posix and Posix paths on Windows.

I do not know how common this case, and how common the opposite case, when we only usegethostname(), but notgethostbyname(). We should guess what would be more useful for users without having any data.

Doc/library/urllib.request.rst OutdatedShow resolvedHide resolved

picnixz reviewed

Apr 24, 2025

View reviewed changes

Doc/library/urllib.request.rst OutdatedShow resolvedHide resolved

Misc/NEWS.d/next/Library/2024-11-14-21-17-48.gh-issue-126838.Yr5vKF.rst OutdatedShow resolvedHide resolved

barneygaleand others added2 commits

April 28, 2025 17:48

Apply suggestions from code review

9e75357

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Address some review feedback

873c19a

Copy link

ContributorAuthor

barneygale commentedApr 28, 2025

Thanks for the reviews - sorry for my slow response

serhiy-storchaka reviewed

Apr 28, 2025

View reviewed changes

Doc/library/urllib.request.rst OutdatedShow resolvedHide resolved

Misc/NEWS.d/next/Library/2024-11-14-21-17-48.gh-issue-126838.Yr5vKF.rst OutdatedShow resolvedHide resolved

zooba reviewed

Apr 30, 2025

View reviewed changes

Lib/urllib/request.py OutdatedShow resolvedHide resolved

barneygaleand others added2 commits

May 5, 2025 12:52

Update Lib/urllib/request.py

4bbeef6

Co-authored-by: Steve Dower <steve.dower@microsoft.com>

argument -> parameter

2a42d88

Copy link

ContributorAuthor

barneygale commentedMay 5, 2025

@serhiy-storchaka sorry for the short notice, but would you mind if I merge this in time for 3.14 beta 1? I can log youroutstanding feedback as a follow-up issue; I suspect we can address it during the 3.14 beta period without affecting the API.

barneygale requested a review fromserhiy-storchaka

May 5, 2025 12:08

serhiy-storchaka approved these changes

May 5, 2025

View reviewed changes

Copy link

Member

serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

I do not actually know what to do when we want to parse the "file:" URL on different machine, especially if they are Windows and Posix. On Windows, we can always interpret the host name as a UNC path. On Posix we can only ignore it or raise an exception if it is not localhost.