Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131798: Usesym_new_type instead ofsym_new_not_null for _BUILD_STRING, _BUILD_SET#132564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Fidget-Spinner merged 13 commits intopython:mainfromZheaoli:manjusaka/build-string
Apr 27, 2025

Conversation

Zheaoli
Copy link
Contributor

@ZheaoliZheaoli commentedApr 15, 2025
edited by bedevere-appbot
Loading

This PR is under developing, not ready for review

Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
ContributorAuthor

@brandtbucher Hi Brandt, I might need some help here.

I have already optimization path for_BUILD_STRING(I think we just need setup the const after we check all theopargs string on stack.

But I got a little bit confused for_BUILD_STRING. If I'm correct,_BUILD_SLICE is equal withBUILD_SLISE, I'm not sure it's necessary add an optimization path for_BUILD_SLICE. Theresult is const or not is not related with the argument?(not sure about this)

@brandtbucher
Copy link
Member

Hi@Zheaoli! Let's start by just setting the output types for these. I think maybe the constant output stuff may not be needed after all, due toGH-132733.

Zheaoli reacted with thumbs up emojiZheaoli reacted with heart emoji

Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@ZheaoliZheaoli changed the titlegh-131798: Add JIT path for _BUILD_STRINGgh-131798: Usesym_new_type instead ofsym_new_not_null for _BUILD_STRING, _BUILD_SLICEApr 26, 2025
@ZheaoliZheaoli changed the titlegh-131798: Usesym_new_type instead ofsym_new_not_null for _BUILD_STRING, _BUILD_SLICEgh-131798: Usesym_new_type instead ofsym_new_not_null for _BUILD_STRING, _BUILD_SETApr 26, 2025
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
@ZheaoliZheaoli marked this pull request as ready for reviewApril 26, 2025 12:10
Zheaoliand others added2 commitsApril 27, 2025 12:08
@Fidget-SpinnerFidget-Spinner merged commit614d792 intopython:mainApr 27, 2025
58 checks passed
@ZheaoliZheaoli deleted the manjusaka/build-string branchApril 27, 2025 12:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Zheaoli@brandtbucher@Fidget-Spinner

[8]ページ先頭

©2009-2025 Movatter.jp