Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-132554: "Virtual" iterators#132555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
markshannon wants to merge26 commits intopython:main
base:main
Choose a base branch
Loading
fromfaster-cpython:virtual-iterators

Conversation

markshannon
Copy link
Member

@markshannonmarkshannon commentedApr 15, 2025•
edited by bedevere-appbot
Loading

Just a draft PR until I have performance numbers.

@markshannon
Copy link
MemberAuthor

Performance is good. Nothing amazing, but a small speedup.

Stats show no significant changes

@Fidget-Spinner
Copy link
Member

@markshannon I don't think it matters here, but you didn't update inhttps://github.com/python/cpython/pull/132545/filesPy_TAG_BITS to3. It's still1. I know it "technically" doesn't matter because we use a bitshift to zero it out, but we should still update it to be consistent.

@markshannon
Copy link
MemberAuthor

@markshannon I don't think it matters here, but you didn't update inhttps://github.com/python/cpython/pull/132545/filesPy_TAG_BITS to3. It's still1. I know it "technically" doesn't matter because we use a bitshift to zero it out, but we should still update it to be consistent.

Fixed in#134244

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner left review comments

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@markshannon@Fidget-Spinner@iritkatriel
[8]ページ先頭
©2009-2025 Movatter.jp