Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-81793: Always call linkat() from os.link(), if available#132517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedApr 14, 2025•
edited
Loading

This fixes os.link() on platforms (like Linux and OpenIndiana) where the system link() function does not follow symlinks.

  • On Linuxand OpenIndiana, it now follows symlinks by default or if follow_symlinks=True is specified.
  • On Windows, it now raises error if follow_symlinks=True is passed.
  • On macOS, it now raises error if follow_symlinks=False is passed and the system linkat() function is not available at runtime.
  • On other platforms, it now raises error if follow_symlinks is passed with a value that does not match the system link() function behavior if if the behavior is not known.

📚 Documentation preview 📚:https://cpython-previews--132517.org.readthedocs.build/

takluyver reacted with thumbs up emoji
This fixes os.link() on platforms (like Linux and OpenIndiana) where thesystem link() function does not follow symlinks.* On Linux and OpenIndiana, it now follows symlinks by default and if  follow_symlinks=True is specified.* On Windows, it now raises error if follow_symlinks=True is passed.* On macOS, it now raises error if follow_symlinks=False is passed and  the system linkat() function is not available at runtime.* On other platforms, it now raises error if follow_symlinks is passed  with a value that does not match the system link() function behavior  if if the behavior is not known.Co-authored-by: Joachim Henke <37883863+jo-he@users.noreply.github.com>Co-authored-by: Thomas Kluyver <takowl@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for grammar fixes@StanFromIreland.

StanFromIreland reacted with heart emoji
@StanFromIreland
Copy link
Contributor

No problem:-)

@serhiy-storchakaserhiy-storchaka merged commit5a57248 intopython:mainMay 4, 2025
42 checks passed
@serhiy-storchakaserhiy-storchaka deleted the os-link-follow_symlinks branchMay 4, 2025 14:24
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotaarch64 Android 3.x (tier-3) has failed when building commit5a57248.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/2228) and take a look at the build logs.
  4. Check if the failure is related to this commit (5a57248) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/2228

Failed tests:

  • test_posix

Failed subtests:

  • test_link_follow_symlinks - test.test_posix.PosixTester.test_link_follow_symlinks

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_posix.py", line1548, intest_link_follow_symlinks    posix.link(symlink, link,follow_symlinks=False)~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^PermissionError:[Errno 13] Permission denied: '@test_1785_tmpæsymlink' -> '@test_1785_tmpælink_nofollow'Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_posix.py", line1560, intest_link_follow_symlinks    posix.link(symlink, link,follow_symlinks=True)~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^PermissionError:[Errno 13] Permission denied: '@test_1785_tmpæsymlink' -> '@test_1785_tmpælink_following'Traceback (most recent call last):  File"/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_posix.py", line1537, intest_link_follow_symlinks    posix.link(symlink, link)~~~~~~~~~~^^^^^^^^^^^^^^^PermissionError:[Errno 13] Permission denied: '@test_1785_tmpæsymlink' -> '@test_1785_tmpælink'

diegorusso added a commit to diegorusso/cpython that referenced this pull requestMay 4, 2025
* origin/main: (111 commits)pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385)pythongh-131178: Add tests for `ast` command-line interface (python#133329)  Regenerate pcbuild.sln in Visual Studio 2022 (python#133394)pythongh-133042: disable HACL* HMAC on Emscripten (python#133064)pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387)pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946)pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388)pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830)pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368)pythongh-132457: make staticmethod and classmethod generic (python#132460)pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812)pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490)pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517)pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628)pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358)  bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226)pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287)pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364)pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027)pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284)  ...
@freakboy3742
Copy link
Contributor

Not sure of the source of the Android failure here, but it looks related to the subject ticket. Investigation ongoing.

@serhiy-storchaka
Copy link
MemberAuthor

It was fixed on#133388.

freakboy3742 reacted with thumbs up emoji

@freakboy3742
Copy link
Contributor

It was fixed on#133388.

Thanks for the fast response!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@serhiy-storchaka@StanFromIreland@bedevere-bot@freakboy3742
[8]ページ先頭
©2009-2025 Movatter.jp