Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-130655: Add a test for big-endian MO files ingettext#132469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 1 commit intopython:mainfromtomasr8:gettext-bigendian
May 1, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedApr 13, 2025•
edited by bedevere-appbot
Loading

MO files can be stored either in little or big-endian format. Which is which is dictated by the file header.
All our test MO files are currently little-endian. We should have at least one test with big-endian as well.

@tomasr8tomasr8 added skip news needs backport to 3.13bugs and security fixes labelsApr 13, 2025
@bedevere-appbedevere-appbot added awaiting review testsTests in the Lib/test dir labelsApr 13, 2025
Copy link
Contributor

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

tomasr8 reacted with thumbs up emoji
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@@ -115,6 +115,23 @@
0x62, 0x61, 0x72, 0x00, # Message data
]))


GNU_MO_DATA_BIG_ENDIAN = base64.b64encode(bytes([

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is weird to use b64encode here, and then decode it back. In future we may use bytes literals.

tomasr8 reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Noted, thanks for the review!

@serhiy-storchakaserhiy-storchaka merged commit474f296 intopython:mainMay 1, 2025
54 checks passed
@miss-islington-app
Copy link

Thanks@tomasr8 for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 1, 2025
…nGH-132469)(cherry picked from commit474f296)Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

GH-133248 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 1, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 1, 2025
…32469) (GH-133248)(cherry picked from commit474f296)Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@tomasr8tomasr8 deleted the gettext-bigendian branchMay 1, 2025 12:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@tomasr8@serhiy-storchaka@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp