Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131798: Usesym_new_type
instead ofsym_new_not_null
for_BUILD_LIST
,_BUILD_SLICE
, and_BUILD_MAP
#132434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-131798: Usesym_new_type
instead ofsym_new_not_null
for_BUILD_LIST
,_BUILD_SLICE
, and_BUILD_MAP
#132434
Uh oh!
There was an error while loading.Please reload this page.
Conversation
TeamSpen210 commentedApr 12, 2025
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
@Fidget-Spinner I think I still have some work for this PR A few days ago, In#132289,@brandtbucher setup optimization path for I'm not sure this is what we want to get(I guess it's, so maybe we just need to patch the test?) |
sym_new_type
instead ofsym_new_not_null
for _BUILD_LIST, _BUILD_SET, _BUILD_MAPsym_new_type
instead ofsym_new_not_null
for _BUILD_LIST, _BUILD_SLICE, _BUILD_MAPsym_new_type
instead ofsym_new_not_null
for _BUILD_LIST, _BUILD_SLICE, _BUILD_MAPsym_new_type
instead ofsym_new_not_null
for_BUILD_LIST
,_BUILD_SLICE
, and_BUILD_MAP
brandtbucher commentedApr 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@Zheaoli, that's actually agood thing! The additional information that you've added to the optimizer for (I don't think writing a test for the |
Zheaoli commentedApr 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, I guess the |
5101fc8
to1e69348
Compare@@ -1706,7 +1706,7 @@ def f(n): | |||
self.assertEqual(res, 2 * TIER2_THRESHOLD) | |||
self.assertIsNotNone(ex) | |||
uops = get_opnames(ex) | |||
self.assertEqual(uops.count("_GUARD_NOS_LIST"),1) | |||
self.assertEqual(uops.count("_GUARD_NOS_LIST"),0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please update the comment above and changeGuarded
toUnguarded
. The guard has now been removed.
Same fortest_remove_guard_for_known_type_dict
… _BUILD_LIST, _BUILD_SET, _BUILD_MAPSigned-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
Signed-off-by: Manjusaka <me@manjusaka.me>
8d55bc4
to839a749
Compare@Zheaoli please don't force push, just normal push so we can see the commit diff. We will squash and merge at the end as one commit. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks again! Great job.
b9e88ff
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.