Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-132336: Only mark slow path functions used by the interpreter loop as noinline in free-threaded builds#132424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
…e in free-threaded buildsThere is concern that this is slowing down the default build.
| @@ -374,6 +374,14 @@ extern "C" { | |||
| # define Py_NO_INLINE | |||
| #endif | |||
| // FT_NO_INLINE | |||
| // Disable inlining of a function only in the free-threaded build. | |||
| #if defined(Py_GIL_DISABLED) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Referring to Marks comment#132336 (comment)
What we do or do not want to inline depends on whether it is a tail-calling build or not.
this should maybe depend on tail-calling, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Benchmark results suggest that it doesn't matter.
Uh oh!
There was an error while loading.Please reload this page.
There is concern that this is slowing down the default build.